[PR #317] [MERGED] fixes and updates #497

New issue

Closed

opened 2026-02-27 15:58:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/317
Author: @catborise
Created: 6/4/2020
Status: ✅ Merged
Merged: 6/7/2020
Merged by: @retspen

Base: master ← Head: rets

📝 Commits (10+)

d283e0e remove unused resize request from instance
22cb8f7 fix code conventions for pylint
e911db8 fix isinstance method call
e72073f fix setting title/description function (xml -> lxml)
966da06 get host info from compute not instance
d384c91 stop getting status info before instance delete to prevent domain not found error
b48b112 Update Ace XML Editor 1.4.10 - Move seperate dir
0c72ccd add localhost is up checking
566a9d4 add host status checking for statistic request
11fcb6c show socket error & check with is True

📊 Changes

30 files changed (+336 additions, -223 deletions)

View changed files

📝 Dockerfile (+0 -1)
📝 accounts/models.py (+2 -2)
📝 computes/templates/overview.html (+22 -21)
📝 computes/views.py (+30 -1)
📝 console/views.py (+1 -1)
📝 create/templates/create_instance_w1.html (+1 -1)
📝 create/views.py (+10 -6)
📝 datasource/urls.py (+1 -2)
📝 datasource/views.py (+28 -13)
📝 instances/templates/instance.html (+19 -13)
📝 instances/views.py (+9 -44)
📝 networks/templates/network.html (+1 -1)
📝 nwfilters/templates/nwfilter.html (+1 -1)
📝 nwfilters/templates/nwfilters.html (+1 -1)
📝 nwfilters/views.py (+6 -4)
➖ static/js/ace.js (+0 -16)
➕ static/js/ace/ace.js (+17 -0)
📝 static/js/ace/ext-textarea.js (+1 -0)
📝 static/js/ace/mode-xml.js (+1 -0)
➕ static/js/ace/worker-xml.js (+2 -0)

...and 10 more files

📄 Description

hi @retspen,

i have some updates. But i will divide them multiple merge request.
For now only fixing and updates

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/317 **Author:** [@catborise](https://github.com/catborise) **Created:** 6/4/2020 **Status:** ✅ Merged **Merged:** 6/7/2020 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `rets` --- ### 📝 Commits (10+) - [`d283e0e`](https://github.com/retspen/webvirtcloud/commit/d283e0e1b3ec8dde9b869eb27a2593a672609998) remove unused resize request from instance - [`22cb8f7`](https://github.com/retspen/webvirtcloud/commit/22cb8f702ad9bc7bf73584b1ec4d522211f1154e) fix code conventions for pylint - [`e911db8`](https://github.com/retspen/webvirtcloud/commit/e911db81247f9234e39ab0baef8f457e4959f877) fix isinstance method call - [`e72073f`](https://github.com/retspen/webvirtcloud/commit/e72073fa79b85c39bb1a225b1ef232b1f6e43655) fix setting title/description function (xml -> lxml) - [`966da06`](https://github.com/retspen/webvirtcloud/commit/966da065b4633d878418226c164133a2e1eb8f45) get host info from compute not instance - [`d384c91`](https://github.com/retspen/webvirtcloud/commit/d384c914a40ef90abccb9b0c84c07dc9c1d7ae1a) stop getting status info before instance delete to prevent domain not found error - [`b48b112`](https://github.com/retspen/webvirtcloud/commit/b48b112a40fdf74721963f501bab4dd3c1a79ee8) Update Ace XML Editor 1.4.10 - Move seperate dir - [`0c72ccd`](https://github.com/retspen/webvirtcloud/commit/0c72ccd06640c12b30e121555d18e5c88e8f9219) add localhost is up checking - [`566a9d4`](https://github.com/retspen/webvirtcloud/commit/566a9d446a906ae46e48de5a1848825fe226e4d2) add host status checking for statistic request - [`11fcb6c`](https://github.com/retspen/webvirtcloud/commit/11fcb6c0f3d47080eb3192584fab4715cbaaf986) show socket error & check with is True ### 📊 Changes **30 files changed** (+336 additions, -223 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+0 -1) 📝 `accounts/models.py` (+2 -2) 📝 `computes/templates/overview.html` (+22 -21) 📝 `computes/views.py` (+30 -1) 📝 `console/views.py` (+1 -1) 📝 `create/templates/create_instance_w1.html` (+1 -1) 📝 `create/views.py` (+10 -6) 📝 `datasource/urls.py` (+1 -2) 📝 `datasource/views.py` (+28 -13) 📝 `instances/templates/instance.html` (+19 -13) 📝 `instances/views.py` (+9 -44) 📝 `networks/templates/network.html` (+1 -1) 📝 `nwfilters/templates/nwfilter.html` (+1 -1) 📝 `nwfilters/templates/nwfilters.html` (+1 -1) 📝 `nwfilters/views.py` (+6 -4) ➖ `static/js/ace.js` (+0 -16) ➕ `static/js/ace/ace.js` (+17 -0) 📝 `static/js/ace/ext-textarea.js` (+1 -0) 📝 `static/js/ace/mode-xml.js` (+1 -0) ➕ `static/js/ace/worker-xml.js` (+2 -0) _...and 10 more files_ </details> ### 📄 Description hi @retspen, i have some updates. But i will divide them multiple merge request. For now only fixing and updates --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>