[PR #276] [CLOSED] Mark the unreachable computes properly #486

Closed
opened 2026-02-27 15:58:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/276
Author: @tmshlvck
Created: 1/1/2020
Status: Closed

Base: masterHead: master


📝 Commits (2)

  • 9aee37a Mark the unreachable computes properly
  • de229ba Experimental: Allow migration with non-shared disk

📊 Changes

2 files changed (+6 additions, -4 deletions)

View changed files

📝 computes/templates/computes.html (+3 -3)
📝 vrtManager/instance.py (+3 -1)

📄 Description

When a compute can not be connected (for whatever reason) mark it as
not connected in the template.

The generic check

if compute.status

is not enough because the status variable can contain a string with a
connection error.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/276 **Author:** [@tmshlvck](https://github.com/tmshlvck) **Created:** 1/1/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`9aee37a`](https://github.com/retspen/webvirtcloud/commit/9aee37ab60ff71d241bb6ac7967fd0d3fca5f3ba) Mark the unreachable computes properly - [`de229ba`](https://github.com/retspen/webvirtcloud/commit/de229ba81a7b272d9a4cfde4e757c3225f07c55e) Experimental: Allow migration with non-shared disk ### 📊 Changes **2 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `computes/templates/computes.html` (+3 -3) 📝 `vrtManager/instance.py` (+3 -1) </details> ### 📄 Description When a compute can not be connected (for whatever reason) mark it as not connected in the template. The generic check if compute.status is not enough because the status variable can contain a string with a connection error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 15:58:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/webvirtcloud#486
No description provided.