[PR #270] [MERGED] New options for instance create & handle nvram & migrate options #485

New issue

Closed

opened 2026-02-27 15:58:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/270
Author: @catborise
Created: 12/19/2019
Status: ✅ Merged
Merged: 12/19/2019
Merged by: @retspen

Base: master ← Head: master

📝 Commits (10+)

3752ad5 Hypervisor list rearrange view on Host overview, if it is more than 4
b27d27d fix variable to show bus types
b91f1cc Add UEFI Architecture Patterns
3a925af fix connection undefined error while getting volumes
28b001e Add capability to remove UEFI instances: Add option for NVRAM delete
dd16a5b Enrich Instance Create operation: -add capability to create arm, ppc, i686, aarch64 instances, -add option to choose firmware, -add options to choose chipset. -add capability to choose volume driver options. -add new default settings
8df71ef Update django requirement 1.11.23 -> 1.11.26, update libvirt-api: 5.3 -> 5.10 and lxml
a5e77ef How to update section change: remove creating virtual env command
28ea64c Fix column offset for small screens
ff96ce6 Storage.py upper constant variable names. make mode and suffix variables a parameter

📊 Changes

22 files changed (+1090 additions, -292 deletions)

View changed files

📝 .travis.yml (+1 -1)
📝 README.md (+5 -1)
📝 computes/templates/overview.html (+17 -18)
📝 computes/urls.py (+7 -4)
📝 computes/views.py (+52 -4)
📝 conf/requirements.txt (+3 -3)
📝 create/forms.py (+5 -3)
➕ create/templates/create_instance_w1.html (+151 -0)
📝 create/templates/create_instance_w2.html (+190 -74)
📝 create/views.py (+110 -34)
📝 instances/templates/add_instance_volume.html (+1 -1)
📝 instances/templates/allinstances.html (+3 -2)
📝 instances/templates/instance.html (+29 -3)
📝 instances/templates/instances.html (+2 -10)
📝 instances/views.py (+42 -19)
📝 storages/views.py (+1 -1)
📝 vrtManager/connection.py (+233 -31)
📝 vrtManager/create.py (+100 -52)
📝 vrtManager/instance.py (+81 -23)
📝 vrtManager/storage.py (+12 -7)

...and 2 more files

📄 Description

hi retspen,

There are many additions, bug fix, and enchancements:

Big one is instance creation: Choosing firmware, chipset, and machine types are possible...
Delete addition: delete instance that has nvram
Migrate: rewrite migrate function: handle compress, postcopy and autoconverge
Options to settings: User can add some keywords to domain disk xml, machine type, vcpu model
Clone: handle nvram while cloning instances.
Requirements update
Typo fixes and some error fixes and more

thanks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/270 **Author:** [@catborise](https://github.com/catborise) **Created:** 12/19/2019 **Status:** ✅ Merged **Merged:** 12/19/2019 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`3752ad5`](https://github.com/retspen/webvirtcloud/commit/3752ad5160c05bc8d28a5d0fedca135b82fa7e70) Hypervisor list rearrange view on Host overview, if it is more than 4 - [`b27d27d`](https://github.com/retspen/webvirtcloud/commit/b27d27d532280917c27144ce8582ec5668ab5937) fix variable to show bus types - [`b91f1cc`](https://github.com/retspen/webvirtcloud/commit/b91f1cc36b102b4560946522394ee62a13a62567) Add UEFI Architecture Patterns - [`3a925af`](https://github.com/retspen/webvirtcloud/commit/3a925af3c2af1035183f086080104e8f69d83b71) fix connection undefined error while getting volumes - [`28b001e`](https://github.com/retspen/webvirtcloud/commit/28b001e7cbedc932968242af0478219afe34df7e) Add capability to remove UEFI instances: Add option for NVRAM delete - [`dd16a5b`](https://github.com/retspen/webvirtcloud/commit/dd16a5b2d5f2434780c7c4a7e8441f3388cce101) Enrich Instance Create operation: -add capability to create arm, ppc, i686, aarch64 instances, -add option to choose firmware, -add options to choose chipset. -add capability to choose volume driver options. -add new default settings - [`8df71ef`](https://github.com/retspen/webvirtcloud/commit/8df71efdcaef64a709abbec26d0ee167dc5b1a01) Update django requirement 1.11.23 -> 1.11.26, update libvirt-api: 5.3 -> 5.10 and lxml - [`a5e77ef`](https://github.com/retspen/webvirtcloud/commit/a5e77ef01e21f67d2c0b5d06c6b6447edb206f8a) How to update section change: remove creating virtual env command - [`28ea64c`](https://github.com/retspen/webvirtcloud/commit/28ea64cd166f2fd6d9f7c12b2f4399a7cc8aa16b) Fix column offset for small screens - [`ff96ce6`](https://github.com/retspen/webvirtcloud/commit/ff96ce664857ac48e3f0f13a7d0d5d5d8e1d7de1) Storage.py upper constant variable names. make mode and suffix variables a parameter ### 📊 Changes **22 files changed** (+1090 additions, -292 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -1) 📝 `README.md` (+5 -1) 📝 `computes/templates/overview.html` (+17 -18) 📝 `computes/urls.py` (+7 -4) 📝 `computes/views.py` (+52 -4) 📝 `conf/requirements.txt` (+3 -3) 📝 `create/forms.py` (+5 -3) ➕ `create/templates/create_instance_w1.html` (+151 -0) 📝 `create/templates/create_instance_w2.html` (+190 -74) 📝 `create/views.py` (+110 -34) 📝 `instances/templates/add_instance_volume.html` (+1 -1) 📝 `instances/templates/allinstances.html` (+3 -2) 📝 `instances/templates/instance.html` (+29 -3) 📝 `instances/templates/instances.html` (+2 -10) 📝 `instances/views.py` (+42 -19) 📝 `storages/views.py` (+1 -1) 📝 `vrtManager/connection.py` (+233 -31) 📝 `vrtManager/create.py` (+100 -52) 📝 `vrtManager/instance.py` (+81 -23) 📝 `vrtManager/storage.py` (+12 -7) _...and 2 more files_ </details> ### 📄 Description hi retspen, There are many additions, bug fix, and enchancements: 1. Big one is instance creation: Choosing firmware, chipset, and machine types are possible... 2. Delete addition: delete instance that has nvram 3. Migrate: rewrite migrate function: handle compress, postcopy and autoconverge 4. Options to settings: User can add some keywords to domain disk xml, machine type, vcpu model 5. Clone: handle nvram while cloning instances. 6. Requirements update 7. Typo fixes and some error fixes and more thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>