[PR #247] [MERGED] Fix bug with err instead of True in connection_manager.host_is_up, which lead to freeze in panel if compute is down #468

New issue

Closed

opened 2026-02-27 15:58:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/247
Author: @ilyatrefilov
Created: 7/3/2019
Status: ✅ Merged
Merged: 7/22/2019
Merged by: @retspen

Base: master ← Head: fix_long_instance_waiting

📝 Commits (1)

ac3ec24 Fix bug with err instead of True in connection_manager.host_is_up, which

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 instances/views.py (+3 -2)

📄 Description

host_is_up function returns either True or err-like object, so we can't compare status with any object. Instead comparison should be made against True.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/247 **Author:** [@ilyatrefilov](https://github.com/ilyatrefilov) **Created:** 7/3/2019 **Status:** ✅ Merged **Merged:** 7/22/2019 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `fix_long_instance_waiting` --- ### 📝 Commits (1) - [`ac3ec24`](https://github.com/retspen/webvirtcloud/commit/ac3ec24332e1ea84890683ce577a951361d9f023) Fix bug with err instead of True in connection_manager.host_is_up, which ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `instances/views.py` (+3 -2) </details> ### 📄 Description host_is_up function returns either True or err-like object, so we can't compare status with any object. Instead comparison should be made against True. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>