[PR #208] [MERGED] New Features: Add/Remove CD-Rom Device, Enchance VM Creation #459

New issue

Closed

opened 2026-02-27 15:58:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/208
Author: @catborise
Created: 12/14/2018
Status: ✅ Merged
Merged: 12/18/2018
Merged by: @retspen

Base: master ← Head: master

📝 Commits (10+)

f68d53f upgrade chartjs 1.0.2 -> 1.1.1
69be623 upgrade bootstrap-multiselect to v0.9.15
fab3b28 add filter bar to 'add disk' dropdown. Limit the size of dropdown list.
8ecd453 fix: initialize used_size variable. it causes error if instance disks are deleted.
d3b43b2 add hide/show all instances funtionality
5872700 remove caret: bootstrap-multiselect, inheritClass
605d24d define allow_admin_or_not_template variable, template cannot use parenthesis @honza801
40ada89 add log message when an instance is created
45c3f9b index_grouped: remove unused data-sortable. index_nongrouped: add trans statement for actions
4eda0fb add chevron-toggle to collapse_all on grouped_index

📊 Changes

18 files changed (+1944 additions, -527 deletions)

View changed files

📝 computes/templates/overview.html (+9 -1)
📝 computes/urls.py (+4 -2)
📝 computes/views.py (+32 -1)
📝 create/forms.py (+2 -1)
📝 create/templates/create_instance.html (+180 -59)
📝 create/views.py (+42 -12)
📝 instances/templates/add_instance_volume.html (+14 -14)
📝 instances/templates/allinstances_index_grouped.html (+14 -4)
📝 instances/templates/allinstances_index_nongrouped.html (+1 -1)
📝 instances/templates/instance.html (+57 -41)
📝 instances/views.py (+55 -33)
📝 static/css/bootstrap-multiselect.css (+1 -38)
📝 static/js/Chart.min.js (+3 -3)
📝 static/js/bootstrap-multiselect.js (+1417 -276)
📝 storages/views.py (+15 -4)
📝 vrtManager/connection.py (+32 -2)
📝 vrtManager/create.py (+45 -25)
📝 vrtManager/instance.py (+21 -10)

📄 Description

Hi Retspen,

If it is appropriate please accept it. Thanks.
Major Changes:

Upgrade chartjs, bootstrap-multiselect js files.
Adding removing cd-rom devices function added
Custom instance creation enriched:
3.1. Add disk type selection.
3.2. Get volumes list with ajax. it provides speed.
3.3. Select storage to add volume. it provides clearity
3.4. Add disk type/bus select options
3.5. Add qemu-guest-agent option while creating instance.
Fix some typos.
Add qemu & libvirt version info to compute overview.
Some small visual changes/enhancements

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/208 **Author:** [@catborise](https://github.com/catborise) **Created:** 12/14/2018 **Status:** ✅ Merged **Merged:** 12/18/2018 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`f68d53f`](https://github.com/retspen/webvirtcloud/commit/f68d53f3e483b1796055be5fb5cea0e03e088475) upgrade chartjs 1.0.2 -> 1.1.1 - [`69be623`](https://github.com/retspen/webvirtcloud/commit/69be623eeb1eab4d29956d7cd28564829dde49df) upgrade bootstrap-multiselect to v0.9.15 - [`fab3b28`](https://github.com/retspen/webvirtcloud/commit/fab3b2891f2670bfb1d912ceb26bacd8adc557a8) add filter bar to 'add disk' dropdown. Limit the size of dropdown list. - [`8ecd453`](https://github.com/retspen/webvirtcloud/commit/8ecd453efe4f41429d04dcc78b902d15ed9a00ce) fix: initialize used_size variable. it causes error if instance disks are deleted. - [`d3b43b2`](https://github.com/retspen/webvirtcloud/commit/d3b43b2e6aad944a520cb55d7b55bfe5706653a4) add hide/show all instances funtionality - [`5872700`](https://github.com/retspen/webvirtcloud/commit/5872700455a81dde1bfff831f475ea9f31fc07f6) remove caret: bootstrap-multiselect, inheritClass - [`605d24d`](https://github.com/retspen/webvirtcloud/commit/605d24d699d18baa0301ece96f27edda181b8976) define allow_admin_or_not_template variable, template cannot use parenthesis @honza801 - [`40ada89`](https://github.com/retspen/webvirtcloud/commit/40ada89c4a4f3d360aafba2611fcd47fe3218d2d) add log message when an instance is created - [`45c3f9b`](https://github.com/retspen/webvirtcloud/commit/45c3f9b1767d5cfe0521d16903de9e8ebe7ab4c6) index_grouped: remove unused data-sortable. index_nongrouped: add trans statement for actions - [`4eda0fb`](https://github.com/retspen/webvirtcloud/commit/4eda0fb866b2f7fa0049a16c285fb9c7a1cf39f8) add chevron-toggle to collapse_all on grouped_index ### 📊 Changes **18 files changed** (+1944 additions, -527 deletions) <details> <summary>View changed files</summary> 📝 `computes/templates/overview.html` (+9 -1) 📝 `computes/urls.py` (+4 -2) 📝 `computes/views.py` (+32 -1) 📝 `create/forms.py` (+2 -1) 📝 `create/templates/create_instance.html` (+180 -59) 📝 `create/views.py` (+42 -12) 📝 `instances/templates/add_instance_volume.html` (+14 -14) 📝 `instances/templates/allinstances_index_grouped.html` (+14 -4) 📝 `instances/templates/allinstances_index_nongrouped.html` (+1 -1) 📝 `instances/templates/instance.html` (+57 -41) 📝 `instances/views.py` (+55 -33) 📝 `static/css/bootstrap-multiselect.css` (+1 -38) 📝 `static/js/Chart.min.js` (+3 -3) 📝 `static/js/bootstrap-multiselect.js` (+1417 -276) 📝 `storages/views.py` (+15 -4) 📝 `vrtManager/connection.py` (+32 -2) 📝 `vrtManager/create.py` (+45 -25) 📝 `vrtManager/instance.py` (+21 -10) </details> ### 📄 Description Hi Retspen, If it is appropriate please accept it. Thanks. Major Changes: 1. Upgrade chartjs, bootstrap-multiselect js files. 2. Adding removing cd-rom devices function added 3. Custom instance creation enriched: 3.1. Add disk type selection. 3.2. Get volumes list with ajax. it provides speed. 3.3. Select storage to add volume. it provides clearity 3.4. Add disk type/bus select options 3.5. Add qemu-guest-agent option while creating instance. 4. Fix some typos. 5. Add qemu & libvirt version info to compute overview. 6. Some small visual changes/enhancements --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>