[PR #197] [MERGED] NWFilters Addition & Instances Tab & Other Fixes #454

New issue

Closed

opened 2026-02-27 15:58:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/197
Author: @catborise
Created: 10/11/2018
Status: ✅ Merged
Merged: 10/30/2018
Merged by: @retspen

Base: master ← Head: master

📝 Commits (10+)

3f1acf0 Add NWFilters
1802ad0 Check usage of filter refs from domains.
35bc8c6 Add NWFilters
7f2104c Check usage of filter refs from domains.
a3a8814 add nwfilters app
658309f Merge branch 'nwfilters' of https://github.com/catborise/webvirtcloud into nwfilters
f45666d Merge branch 'nwfilters'
4d14fdc selection added to domain creation for nwfilters. Add nwfilter option while adding network card. NWfilters minor fixes
812bbb2 console-spice-full fix scheme wss when accessing from https
a4bea0e Merge branch 'master' of github.com:honza801/webvirtcloud

📊 Changes

55 files changed (+5240 additions, -1536 deletions)

View changed files

📝 accounts/templates/login.html (+1 -1)
📝 computes/templates/overview.html (+7 -1)
📝 computes/urls.py (+22 -5)
📝 computes/views.py (+1 -1)
📝 console/templates/console-base.html (+1 -1)
📝 console/templates/console-spice-full.html (+3 -0)
📝 console/templates/console-spice-lite.html (+2 -2)
📝 create/forms.py (+1 -0)
📝 create/templates/create_instance.html (+484 -427)
📝 create/views.py (+7 -3)
📝 instances/templates/add_instance_network_block.html (+12 -0)
➕ instances/templates/add_instance_volume.html (+159 -0)
➕ instances/templates/allinstances.html (+184 -0)
📝 instances/templates/allinstances_index_grouped.html (+0 -0)
📝 instances/templates/allinstances_index_nongrouped.html (+0 -0)
📝 instances/templates/instance.html (+188 -127)
📝 instances/templates/instances.html (+139 -122)
📝 instances/urls.py (+1 -0)
📝 instances/views.py (+339 -209)
📝 interfaces/templates/interface.html (+6 -0)

...and 35 more files

📄 Description

Hi retspen,

NWFilters on libvirt added to domains and computes.
Adding/deleting/updating nwfilter rules/references.
Instance Network tab customized and fixed change operation.
- Add network delete option.
- some bugs resolved with network change/add
Making owner(uid,gid) of vm image choosable using settings.py
Add instances tab to computes.(minimal changing, trying to keep structure as design)
Error Fixes
Favicon url fix
Fontawesome update
Hypervisor info revisited
Cache for disk option linked to settings.py
Add volume operations(attach new/existing, detach, delete)
honza801 fixes on master
VM create menu change (collapse -> tab)

Ps. to make it work update settings.py and add nwfilters to apps
please accept it.
Thanks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/197 **Author:** [@catborise](https://github.com/catborise) **Created:** 10/11/2018 **Status:** ✅ Merged **Merged:** 10/30/2018 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`3f1acf0`](https://github.com/retspen/webvirtcloud/commit/3f1acf09ef3f29d8c0cfa565d0cd069d890cfa65) Add NWFilters - [`1802ad0`](https://github.com/retspen/webvirtcloud/commit/1802ad0413df2a009ba7bd23c78223fa726bcdd8) Check usage of filter refs from domains. - [`35bc8c6`](https://github.com/retspen/webvirtcloud/commit/35bc8c67e403f2961127a59ea31bb0334702c782) Add NWFilters - [`7f2104c`](https://github.com/retspen/webvirtcloud/commit/7f2104c19d30f331214943fdbaf34a7237064837) Check usage of filter refs from domains. - [`a3a8814`](https://github.com/retspen/webvirtcloud/commit/a3a8814cc9adee8fe295502d3a3aa7f1694f62ae) add nwfilters app - [`658309f`](https://github.com/retspen/webvirtcloud/commit/658309f022c7715ba7825e1e3e23287b9545f303) Merge branch 'nwfilters' of https://github.com/catborise/webvirtcloud into nwfilters - [`f45666d`](https://github.com/retspen/webvirtcloud/commit/f45666d88bf41893cf83a484d33dfd8c742a9ae4) Merge branch 'nwfilters' - [`4d14fdc`](https://github.com/retspen/webvirtcloud/commit/4d14fdceea517933afa1cca5d625f36c8d4d3530) selection added to domain creation for nwfilters. Add nwfilter option while adding network card. NWfilters minor fixes - [`812bbb2`](https://github.com/retspen/webvirtcloud/commit/812bbb2ccc5ff22926ce322e5c5f9c784e1c86e4) console-spice-full fix scheme wss when accessing from https - [`a4bea0e`](https://github.com/retspen/webvirtcloud/commit/a4bea0e76595c6552352f306a4dddec095ae7220) Merge branch 'master' of github.com:honza801/webvirtcloud ### 📊 Changes **55 files changed** (+5240 additions, -1536 deletions) <details> <summary>View changed files</summary> 📝 `accounts/templates/login.html` (+1 -1) 📝 `computes/templates/overview.html` (+7 -1) 📝 `computes/urls.py` (+22 -5) 📝 `computes/views.py` (+1 -1) 📝 `console/templates/console-base.html` (+1 -1) 📝 `console/templates/console-spice-full.html` (+3 -0) 📝 `console/templates/console-spice-lite.html` (+2 -2) 📝 `create/forms.py` (+1 -0) 📝 `create/templates/create_instance.html` (+484 -427) 📝 `create/views.py` (+7 -3) 📝 `instances/templates/add_instance_network_block.html` (+12 -0) ➕ `instances/templates/add_instance_volume.html` (+159 -0) ➕ `instances/templates/allinstances.html` (+184 -0) 📝 `instances/templates/allinstances_index_grouped.html` (+0 -0) 📝 `instances/templates/allinstances_index_nongrouped.html` (+0 -0) 📝 `instances/templates/instance.html` (+188 -127) 📝 `instances/templates/instances.html` (+139 -122) 📝 `instances/urls.py` (+1 -0) 📝 `instances/views.py` (+339 -209) 📝 `interfaces/templates/interface.html` (+6 -0) _...and 35 more files_ </details> ### 📄 Description Hi retspen, 1. NWFilters on libvirt added to domains and computes. 2. Adding/deleting/updating nwfilter rules/references. 3. Instance Network tab customized and fixed change operation. - Add network delete option. - some bugs resolved with network change/add 4. Making owner(uid,gid) of vm image choosable using settings.py 5. Add instances tab to computes.(minimal changing, trying to keep structure as design) 6. Error Fixes 7. Favicon url fix 8. Fontawesome update 9. Hypervisor info revisited 10. Cache for disk option linked to settings.py 11. Add volume operations(attach new/existing, detach, delete) 12. honza801 fixes on master 13. VM create menu change (collapse -> tab) Ps. to make it work update settings.py and add nwfilters to apps please accept it. Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>