[PR #192] [CLOSED] Add NWFilters/Instances Tab & Fixes #452

New issue

Closed

opened 2026-02-27 15:58:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/192
Author: @catborise
Created: 9/28/2018
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

3f1acf0 Add NWFilters
1802ad0 Check usage of filter refs from domains.
35bc8c6 Add NWFilters
7f2104c Check usage of filter refs from domains.
a3a8814 add nwfilters app
658309f Merge branch 'nwfilters' of https://github.com/catborise/webvirtcloud into nwfilters
f45666d Merge branch 'nwfilters'
4d14fdc selection added to domain creation for nwfilters. Add nwfilter option while adding network card. NWfilters minor fixes
f7d2d24 message.success fix - (request was missing)
5d4a600 success message converted to translate ready

📊 Changes

46 files changed (+4287 additions, -961 deletions)

View changed files

📝 accounts/templates/login.html (+1 -1)
📝 computes/templates/overview.html (+6 -0)
📝 computes/urls.py (+22 -5)
📝 create/forms.py (+1 -0)
📝 create/templates/create_instance.html (+33 -0)
📝 create/views.py (+3 -3)
📝 instances/templates/add_instance_network_block.html (+12 -0)
➕ instances/templates/allinstances.html (+184 -0)
📝 instances/templates/allinstances_index_grouped.html (+0 -0)
📝 instances/templates/allinstances_index_nongrouped.html (+0 -0)
📝 instances/templates/instance.html (+56 -35)
📝 instances/templates/instances.html (+136 -121)
📝 instances/urls.py (+1 -0)
📝 instances/views.py (+254 -189)
📝 interfaces/templates/interface.html (+6 -0)
📝 interfaces/templates/interfaces.html (+6 -0)
📝 networks/templates/network.html (+6 -0)
📝 networks/templates/networks.html (+6 -0)
➕ nwfilters/__init__.py (+0 -0)
➕ nwfilters/admin.py (+6 -0)

...and 26 more files

📄 Description

Hi retspen,

NWFilters on libvirt added to domains and computes.
Adding/deleting/updating nwfilter rules/references.
Instance Network tab customized and fixed change operation. Add network delete option.
some bug fixes applied
Making owner of vm image choosable using settings.py
Add instances tab to computes.(minimal changing, trying to keep structure as design)

please accept it.
Ps. to make it work update settings.py and add nwfilters to apps

Thanks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/192 **Author:** [@catborise](https://github.com/catborise) **Created:** 9/28/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`3f1acf0`](https://github.com/retspen/webvirtcloud/commit/3f1acf09ef3f29d8c0cfa565d0cd069d890cfa65) Add NWFilters - [`1802ad0`](https://github.com/retspen/webvirtcloud/commit/1802ad0413df2a009ba7bd23c78223fa726bcdd8) Check usage of filter refs from domains. - [`35bc8c6`](https://github.com/retspen/webvirtcloud/commit/35bc8c67e403f2961127a59ea31bb0334702c782) Add NWFilters - [`7f2104c`](https://github.com/retspen/webvirtcloud/commit/7f2104c19d30f331214943fdbaf34a7237064837) Check usage of filter refs from domains. - [`a3a8814`](https://github.com/retspen/webvirtcloud/commit/a3a8814cc9adee8fe295502d3a3aa7f1694f62ae) add nwfilters app - [`658309f`](https://github.com/retspen/webvirtcloud/commit/658309f022c7715ba7825e1e3e23287b9545f303) Merge branch 'nwfilters' of https://github.com/catborise/webvirtcloud into nwfilters - [`f45666d`](https://github.com/retspen/webvirtcloud/commit/f45666d88bf41893cf83a484d33dfd8c742a9ae4) Merge branch 'nwfilters' - [`4d14fdc`](https://github.com/retspen/webvirtcloud/commit/4d14fdceea517933afa1cca5d625f36c8d4d3530) selection added to domain creation for nwfilters. Add nwfilter option while adding network card. NWfilters minor fixes - [`f7d2d24`](https://github.com/retspen/webvirtcloud/commit/f7d2d24d0bca6bbe2fa649182f0cec0e47a75b8c) message.success fix - (request was missing) - [`5d4a600`](https://github.com/retspen/webvirtcloud/commit/5d4a6009082bd6218f6a582838118be63cc5c0f5) success message converted to translate ready ### 📊 Changes **46 files changed** (+4287 additions, -961 deletions) <details> <summary>View changed files</summary> 📝 `accounts/templates/login.html` (+1 -1) 📝 `computes/templates/overview.html` (+6 -0) 📝 `computes/urls.py` (+22 -5) 📝 `create/forms.py` (+1 -0) 📝 `create/templates/create_instance.html` (+33 -0) 📝 `create/views.py` (+3 -3) 📝 `instances/templates/add_instance_network_block.html` (+12 -0) ➕ `instances/templates/allinstances.html` (+184 -0) 📝 `instances/templates/allinstances_index_grouped.html` (+0 -0) 📝 `instances/templates/allinstances_index_nongrouped.html` (+0 -0) 📝 `instances/templates/instance.html` (+56 -35) 📝 `instances/templates/instances.html` (+136 -121) 📝 `instances/urls.py` (+1 -0) 📝 `instances/views.py` (+254 -189) 📝 `interfaces/templates/interface.html` (+6 -0) 📝 `interfaces/templates/interfaces.html` (+6 -0) 📝 `networks/templates/network.html` (+6 -0) 📝 `networks/templates/networks.html` (+6 -0) ➕ `nwfilters/__init__.py` (+0 -0) ➕ `nwfilters/admin.py` (+6 -0) _...and 26 more files_ </details> ### 📄 Description Hi retspen, 1. NWFilters on libvirt added to domains and computes. 2. Adding/deleting/updating nwfilter rules/references. 3. Instance Network tab customized and fixed change operation. Add network delete option. 4. some bug fixes applied 5. Making owner of vm image choosable using settings.py 6. Add instances tab to computes.(minimal changing, trying to keep structure as design) please accept it. Ps. to make it work update settings.py and add nwfilters to apps Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>