[PR #195] [CLOSED] Fixes 1810 #451

New issue

Closed

opened 2026-02-27 15:58:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/195
Author: @honza801
Created: 10/2/2018
Status: ❌ Closed

Base: master ← Head: fixes_1810

📝 Commits (5)

812bbb2 console-spice-full fix scheme wss when accessing from https
a4bea0e Merge branch 'master' of github.com:honza801/webvirtcloud
cdb5c4f fix wvmInterface get_ipv4/6: xml_path should specify protocol family
dd3dc08 instance poweron checks is_template attribute. templates should not be started.
3fa3472 console/templates/console-base.html fix html tag

📊 Changes

5 files changed (+28 additions, -15 deletions)

View changed files

📝 console/templates/console-base.html (+1 -1)
📝 console/templates/console-spice-full.html (+3 -0)
📝 console/templates/console-spice-lite.html (+2 -0)
📝 instances/views.py (+16 -8)
📝 vrtManager/interface.py (+6 -6)

📄 Description

hi,

fix console-spice-full https/wss access
vrtManager/interface.py get_ipv4(), get_ipv6(): get correct address family
security fix: an attacker could enable disabled Start button of an instance by browser html edit. instance.is_template check is now performed on the server during the poweron process.

please merge
thanks
fous

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/195 **Author:** [@honza801](https://github.com/honza801) **Created:** 10/2/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fixes_1810` --- ### 📝 Commits (5) - [`812bbb2`](https://github.com/retspen/webvirtcloud/commit/812bbb2ccc5ff22926ce322e5c5f9c784e1c86e4) console-spice-full fix scheme wss when accessing from https - [`a4bea0e`](https://github.com/retspen/webvirtcloud/commit/a4bea0e76595c6552352f306a4dddec095ae7220) Merge branch 'master' of github.com:honza801/webvirtcloud - [`cdb5c4f`](https://github.com/retspen/webvirtcloud/commit/cdb5c4f4128852aa06b3485a47c33e930ee1fba6) fix wvmInterface get_ipv4/6: xml_path should specify protocol family - [`dd3dc08`](https://github.com/retspen/webvirtcloud/commit/dd3dc0861485ce0ba34a1225ef6c637d2e19dd92) instance poweron checks is_template attribute. templates should not be started. - [`3fa3472`](https://github.com/retspen/webvirtcloud/commit/3fa3472477d3baacf3a48ea61540f911c9c81654) console/templates/console-base.html fix html tag ### 📊 Changes **5 files changed** (+28 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `console/templates/console-base.html` (+1 -1) 📝 `console/templates/console-spice-full.html` (+3 -0) 📝 `console/templates/console-spice-lite.html` (+2 -0) 📝 `instances/views.py` (+16 -8) 📝 `vrtManager/interface.py` (+6 -6) </details> ### 📄 Description hi, * fix console-spice-full https/wss access * vrtManager/interface.py get_ipv4(), get_ipv6(): get correct address family * security fix: an attacker could enable disabled Start button of an instance by browser html edit. instance.is_template check is now performed on the server during the poweron process. please merge thanks fous --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>