[PR #176] [MERGED] console fn-keys functionality correction #446

New issue

Closed

opened 2026-02-27 15:58:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/176
Author: @catborise
Created: 8/27/2018
Status: ✅ Merged
Merged: 8/28/2018
Merged by: @retspen

Base: master ← Head: master

📝 Commits (5)

2a5a761 spice config corrections
f73271e missing js files and keyfunctions added
76e6388 novnc ES6 compatibility is not working. I reverse it. Spice/VNC sending ctrl+alt+fn functionality restored.
e9e2185 Update console-spice-full.html
14e145e twice calling function generates two vnc console. ES6 requirement no longer necessary. it is disabled and problem solved.

📊 Changes

58 files changed (+64762 additions, -17444 deletions)

View changed files

📝 console/templates/console-base.html (+20 -20)
📝 console/templates/console-spice-full.html (+17 -29)
📝 console/templates/console-spice-lite.html (+17 -26)
📝 console/templates/console-vnc-full.html (+20 -8)
📝 console/templates/console-vnc-lite.html (+73 -31)
📝 instances/templates/instances.html (+1 -1)
➖ static/js/novnc/app.js (+0 -12069)
📝 static/js/novnc/app/localization.js (+32 -25)
📝 static/js/novnc/app/ui.js (+483 -419)
📝 static/js/novnc/app/webutil.js (+33 -73)
📝 static/js/novnc/core/base64.js (+26 -30)
📝 static/js/novnc/core/des.js (+98 -110)
📝 static/js/novnc/core/display.js (+57 -69)
📝 static/js/novnc/core/encodings.js (+10 -22)
📝 static/js/novnc/core/inflator.js (+8 -20)
📝 static/js/novnc/core/input/domkeytable.js (+188 -193)
📝 static/js/novnc/core/input/fixedkeys.js (+103 -108)
📝 static/js/novnc/core/input/keyboard.js (+66 -78)
📝 static/js/novnc/core/input/keysym.js (+587 -591)
📝 static/js/novnc/core/input/keysymdef.js (+6 -11)

...and 38 more files

📄 Description

hi,
i did update novnc console to 1.0.0 some documents recommend to convert js files to ES6 style to run them on old browsers but after conversion there are some nitty gritty situation appears. it could be bug, i do not know. i reverse the operation.

ctrl-alt-fn functionality did not work with compiled version of novnc but now it is working... thanks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/176 **Author:** [@catborise](https://github.com/catborise) **Created:** 8/27/2018 **Status:** ✅ Merged **Merged:** 8/28/2018 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`2a5a761`](https://github.com/retspen/webvirtcloud/commit/2a5a761f059be8070466281d09bc3d962ecf60c3) spice config corrections - [`f73271e`](https://github.com/retspen/webvirtcloud/commit/f73271e67759b70cc6b4d63568ec69d40f72424f) missing js files and keyfunctions added - [`76e6388`](https://github.com/retspen/webvirtcloud/commit/76e6388ec523ab37d3e6c6af759f93cec440b679) novnc ES6 compatibility is not working. I reverse it. Spice/VNC sending ctrl+alt+fn functionality restored. - [`e9e2185`](https://github.com/retspen/webvirtcloud/commit/e9e2185fb41e73c57ab9b4c7ae4a2d7045cdcaed) Update console-spice-full.html - [`14e145e`](https://github.com/retspen/webvirtcloud/commit/14e145e0d802904ac7618f62bfa73228602f6370) twice calling function generates two vnc console. ES6 requirement no longer necessary. it is disabled and problem solved. ### 📊 Changes **58 files changed** (+64762 additions, -17444 deletions) <details> <summary>View changed files</summary> 📝 `console/templates/console-base.html` (+20 -20) 📝 `console/templates/console-spice-full.html` (+17 -29) 📝 `console/templates/console-spice-lite.html` (+17 -26) 📝 `console/templates/console-vnc-full.html` (+20 -8) 📝 `console/templates/console-vnc-lite.html` (+73 -31) 📝 `instances/templates/instances.html` (+1 -1) ➖ `static/js/novnc/app.js` (+0 -12069) 📝 `static/js/novnc/app/localization.js` (+32 -25) 📝 `static/js/novnc/app/ui.js` (+483 -419) 📝 `static/js/novnc/app/webutil.js` (+33 -73) 📝 `static/js/novnc/core/base64.js` (+26 -30) 📝 `static/js/novnc/core/des.js` (+98 -110) 📝 `static/js/novnc/core/display.js` (+57 -69) 📝 `static/js/novnc/core/encodings.js` (+10 -22) 📝 `static/js/novnc/core/inflator.js` (+8 -20) 📝 `static/js/novnc/core/input/domkeytable.js` (+188 -193) 📝 `static/js/novnc/core/input/fixedkeys.js` (+103 -108) 📝 `static/js/novnc/core/input/keyboard.js` (+66 -78) 📝 `static/js/novnc/core/input/keysym.js` (+587 -591) 📝 `static/js/novnc/core/input/keysymdef.js` (+6 -11) _...and 38 more files_ </details> ### 📄 Description hi, i did update novnc console to 1.0.0 some documents recommend to convert js files to ES6 style to run them on old browsers but after conversion there are some nitty gritty situation appears. it could be bug, i do not know. i reverse the operation. ctrl-alt-fn functionality did not work with compiled version of novnc but now it is working... thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>