[PR #167] [MERGED] some fixing operations and minor additions #442

New issue

Closed

opened 2026-02-27 15:58:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/167
Author: @catborise
Created: 7/30/2018
Status: ✅ Merged
Merged: 8/14/2018
Merged by: @retspen

Base: master ← Head: master

📝 Commits (10+)

7862fa8 variable typo fix
7200a34 fix if there is an exception int get_storage_images mac_auto and cache_mode does not work. So sequence change fixes that.
73ce98b if there is some inactive storages, listing volumes causes exception then breaks.. checking activeness of storage pool fixes that
4769c5c volume filename extension converted to choosable with settings. And file extensions reorganized.
b7150a1 volume filename extensions reorganized.
e7ecf29 volume filename extensions reorganized.
e387c3a Host gets list of all storages active/inactive. If there is some inactive storages it gives error. But it coulde be inactive. It is normal. Changing the behaviour of getting list of storages.
5adeead remove data-sort
332de37 Update settings.py.template
41b80bc libxml2 artifact correction.

📊 Changes

200 files changed (+35034 additions, -11166 deletions)

View changed files

📝 .travis.yml (+1 -1)
📝 README.md (+3 -4)
➕ accounts/migrations/0014_auto_20180808_1436.py (+36 -0)
➕ accounts/migrations/0015_auto_20180808_1449.py (+22 -0)
📝 accounts/models.py (+8 -8)
📝 accounts/templates/account.html (+1 -1)
📝 accounts/templates/accounts-list.html (+1 -1)
📝 accounts/templates/accounts.html (+1 -1)
📝 accounts/templates/login.html (+1 -1)
📝 computes/forms.py (+4 -0)
📝 computes/models.py (+1 -1)
📝 computes/templates/computes.html (+87 -61)
📝 computes/templates/create_comp_block.html (+19 -1)
📝 computes/views.py (+7 -4)
📝 console/novncd (+4 -4)
📝 console/templates/console-base.html (+1 -1)
➕ console/templates/console-spice-full.html (+242 -0)
➕ console/templates/console-spice-lite.html (+262 -0)
➖ console/templates/console-spice.html (+0 -194)
➕ console/templates/console-vnc-full.html (+323 -0)

...and 80 more files

📄 Description

Hi retspen,

after lxml change there were some artifacts have to be cleaned. it is done.
honza wants to keep old style intances pages. it is done with settings variable.
honza solve some clone problems for non admin users.
vm names longer than 20 characters gives error. it is solved by increasing 120 characters.

thanks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/167 **Author:** [@catborise](https://github.com/catborise) **Created:** 7/30/2018 **Status:** ✅ Merged **Merged:** 8/14/2018 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`7862fa8`](https://github.com/retspen/webvirtcloud/commit/7862fa8fdf712ca4a23bb568a4b380252ba71626) variable typo fix - [`7200a34`](https://github.com/retspen/webvirtcloud/commit/7200a34699b2e3e7f94a40e6d5f26a9b42270d8d) fix if there is an exception int get_storage_images mac_auto and cache_mode does not work. So sequence change fixes that. - [`73ce98b`](https://github.com/retspen/webvirtcloud/commit/73ce98b63ef8fd8b149a3f3af4cc9e20c26d2a80) if there is some inactive storages, listing volumes causes exception then breaks.. checking activeness of storage pool fixes that - [`4769c5c`](https://github.com/retspen/webvirtcloud/commit/4769c5cf1b52c8090026c87cb79f4bfb074bbba2) volume filename extension converted to choosable with settings. And file extensions reorganized. - [`b7150a1`](https://github.com/retspen/webvirtcloud/commit/b7150a1fae59b73ac3eb3a7f1fdc97ffb7473fa8) volume filename extensions reorganized. - [`e7ecf29`](https://github.com/retspen/webvirtcloud/commit/e7ecf2935985d5b4252fbc50cb576b9c4bf6367e) volume filename extensions reorganized. - [`e387c3a`](https://github.com/retspen/webvirtcloud/commit/e387c3a21db5a5b2a38de7e89540d3f88dcd0633) Host gets list of all storages active/inactive. If there is some inactive storages it gives error. But it coulde be inactive. It is normal. Changing the behaviour of getting list of storages. - [`5adeead`](https://github.com/retspen/webvirtcloud/commit/5adeead68d2909ffceb54d5afdb34a80dcc0d2ef) remove data-sort - [`332de37`](https://github.com/retspen/webvirtcloud/commit/332de3709b5fbf39e777367435c6841b5c55c23a) Update settings.py.template - [`41b80bc`](https://github.com/retspen/webvirtcloud/commit/41b80bc719a8853aef2e6a1a2e477fd177b8ad0b) libxml2 artifact correction. ### 📊 Changes **200 files changed** (+35034 additions, -11166 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -1) 📝 `README.md` (+3 -4) ➕ `accounts/migrations/0014_auto_20180808_1436.py` (+36 -0) ➕ `accounts/migrations/0015_auto_20180808_1449.py` (+22 -0) 📝 `accounts/models.py` (+8 -8) 📝 `accounts/templates/account.html` (+1 -1) 📝 `accounts/templates/accounts-list.html` (+1 -1) 📝 `accounts/templates/accounts.html` (+1 -1) 📝 `accounts/templates/login.html` (+1 -1) 📝 `computes/forms.py` (+4 -0) 📝 `computes/models.py` (+1 -1) 📝 `computes/templates/computes.html` (+87 -61) 📝 `computes/templates/create_comp_block.html` (+19 -1) 📝 `computes/views.py` (+7 -4) 📝 `console/novncd` (+4 -4) 📝 `console/templates/console-base.html` (+1 -1) ➕ `console/templates/console-spice-full.html` (+242 -0) ➕ `console/templates/console-spice-lite.html` (+262 -0) ➖ `console/templates/console-spice.html` (+0 -194) ➕ `console/templates/console-vnc-full.html` (+323 -0) _...and 80 more files_ </details> ### 📄 Description Hi retspen, after lxml change there were some artifacts have to be cleaned. it is done. honza wants to keep old style intances pages. it is done with settings variable. honza solve some clone problems for non admin users. vm names longer than 20 characters gives error. it is solved by increasing 120 characters. thanks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>