[PR #112] [MERGED] Add an option to allow an user to change VNC settings #425

Closed
opened 2026-02-27 15:58:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/112
Author: @nitmir
Created: 5/9/2016
Status: Merged
Merged: 7/11/2016
Merged by: @retspen

Base: masterHead: user-vnc


📝 Commits (2)

  • 7b3fcd1 Check user permission before delete or resize
  • 7efbfec Add an option to allow an user to change VNC settings

📊 Changes

6 files changed (+45 additions, -2 deletions)

View changed files

accounts/migrations/0004_userinstance_is_vnc.py (+19 -0)
📝 accounts/models.py (+1 -0)
📝 accounts/templates/account.html (+11 -0)
📝 accounts/views.py (+2 -0)
📝 instances/templates/instance.html (+8 -0)
📝 instances/views.py (+4 -2)

📄 Description

We also correct a security bug: permission where not checked before resize or delete and just the web form were changed.

fix #107


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/112 **Author:** [@nitmir](https://github.com/nitmir) **Created:** 5/9/2016 **Status:** ✅ Merged **Merged:** 7/11/2016 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `user-vnc` --- ### 📝 Commits (2) - [`7b3fcd1`](https://github.com/retspen/webvirtcloud/commit/7b3fcd17eaa8a67937c0baa2c46a36e1140c5209) Check user permission before delete or resize - [`7efbfec`](https://github.com/retspen/webvirtcloud/commit/7efbfec17f7adaf0a774a4cfdbb1686032cfe11e) Add an option to allow an user to change VNC settings ### 📊 Changes **6 files changed** (+45 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `accounts/migrations/0004_userinstance_is_vnc.py` (+19 -0) 📝 `accounts/models.py` (+1 -0) 📝 `accounts/templates/account.html` (+11 -0) 📝 `accounts/views.py` (+2 -0) 📝 `instances/templates/instance.html` (+8 -0) 📝 `instances/views.py` (+4 -2) </details> ### 📄 Description We also correct a security bug: permission where not checked before resize or delete and just the web form were changed. fix #107 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 15:58:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/webvirtcloud#425
No description provided.