[PR #111] Use JSON Web Signature and Encryption (JWS & JWE) between webvirtcloud and gstfsd #424

New issue

Open

opened 2026-02-27 15:58:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/111
Author: @nitmir
Created: 5/8/2016
Status: 🔄 Open

Base: master ← Head: gstfsd-auth

📝 Commits (5)

6dc7473 Use JSON Web Signature and Encryption (JWS & JWE) between webvirtcloud and gstfsd
064bd18 Add validation of the field gstfsd_key.
c25a35e Disable autocomplete on the root password input
9db1b06 An empty root password disable the root password
748c167 Genrate random salts fort the root password

📊 Changes

10 files changed (+245 additions, -33 deletions)

View changed files

📝 computes/forms.py (+82 -0)
➕ computes/migrations/0002_compute_gstfsd_key.py (+19 -0)
📝 computes/models.py (+1 -0)
📝 computes/templates/computes.html (+24 -0)
📝 computes/templates/create_comp_block.html (+24 -0)
📝 computes/views.py (+11 -5)
📝 conf/daemon/gstfsd (+38 -7)
📝 conf/requirements.txt (+1 -0)
📝 instances/templates/instance.html (+3 -2)
📝 instances/views.py (+42 -19)

📄 Description

This introduce encryption and signing between webvirtcloud and gstfsd: root password change requests and ssh key change requests are signed and encrypted using a shared secret between webvirtcloud and gstfsd.

On first start, gstfsd generate the shared secret, a JSON Web Key (JWK), and save it in the file /var/lib/gstfsd/SECRET.
You can then add the JWK to computes in webvirtcloud computes panel for webvirtcloud to be able to sign and encrypt request to this compute gstfsd instance. If you try to change a root password without having imported the JWK, an error message tell you how to do so.

This fix #106

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/111 **Author:** [@nitmir](https://github.com/nitmir) **Created:** 5/8/2016 **Status:** 🔄 Open **Base:** `master` ← **Head:** `gstfsd-auth` --- ### 📝 Commits (5) - [`6dc7473`](https://github.com/retspen/webvirtcloud/commit/6dc7473ab05d14d8c3e7a62a1d2b60600c7f7cc7) Use JSON Web Signature and Encryption (JWS & JWE) between webvirtcloud and gstfsd - [`064bd18`](https://github.com/retspen/webvirtcloud/commit/064bd18796c8521809432ee704c722843af2b2db) Add validation of the field gstfsd_key. - [`c25a35e`](https://github.com/retspen/webvirtcloud/commit/c25a35e1b17ed6a156236e5bf24ad9f1db8ae30b) Disable autocomplete on the root password input - [`9db1b06`](https://github.com/retspen/webvirtcloud/commit/9db1b060a62c226ef665674f537b347254b608b8) An empty root password disable the root password - [`748c167`](https://github.com/retspen/webvirtcloud/commit/748c167def19eb7c623d41317ab612d4ebd5e9cf) Genrate random salts fort the root password ### 📊 Changes **10 files changed** (+245 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `computes/forms.py` (+82 -0) ➕ `computes/migrations/0002_compute_gstfsd_key.py` (+19 -0) 📝 `computes/models.py` (+1 -0) 📝 `computes/templates/computes.html` (+24 -0) 📝 `computes/templates/create_comp_block.html` (+24 -0) 📝 `computes/views.py` (+11 -5) 📝 `conf/daemon/gstfsd` (+38 -7) 📝 `conf/requirements.txt` (+1 -0) 📝 `instances/templates/instance.html` (+3 -2) 📝 `instances/views.py` (+42 -19) </details> ### 📄 Description This introduce encryption and signing between webvirtcloud and gstfsd: root password change requests and ssh key change requests are signed and encrypted using a shared secret between webvirtcloud and gstfsd. On first start, gstfsd generate the shared secret, a JSON Web Key (JWK), and save it in the file `/var/lib/gstfsd/SECRET`. You can then add the JWK to computes in webvirtcloud computes panel for webvirtcloud to be able to sign and encrypt request to this compute gstfsd instance. If you try to change a root password without having imported the JWK, an error message tell you how to do so. This fix #106 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>