starred/webvirtcloud

Fork 0

mirror of https://github.com/retspen/webvirtcloud.git synced 2026-04-25 15:35:57 +03:00

[GH-ISSUE #341] 2FA integration #220

New issue

Closed

opened 2026-02-27 15:57:51 +03:00 by kerem · 13 comments

kerem commented

2026-02-27 15:57:51 +03:00

Owner

Originally created by @lord-kyron on GitHub (Jul 3, 2020).
Original GitHub issue: https://github.com/retspen/webvirtcloud/issues/341

@catborise @Real-Gecko - I am opening this issue in order to not forget to try to implement 2FA module for Django as we spoke!

Originally created by @lord-kyron on GitHub (Jul 3, 2020). Original GitHub issue: https://github.com/retspen/webvirtcloud/issues/341 @catborise @Real-Gecko - I am opening this issue in order to not forget to try to implement 2FA module for Django as we spoke!

kerem closed this issue

2026-02-27 15:57:51 +03:00

kerem commented

2026-02-27 15:57:51 +03:00

Author

Owner

@lord-kyron commented on GitHub (Jul 14, 2020):

@catborise @Real-Gecko - since instances is merged, can you look at this now, please?

@lord-kyron commented on GitHub (Jul 14, 2020): @catborise @Real-Gecko - since instances is merged, can you look at this now, please?

kerem commented

2026-02-27 15:57:51 +03:00

Author

Owner

@lord-kyron commented on GitHub (Jul 27, 2020):

@Real-Gecko @catborise - can you make some last tries to implement this :( I know @Real-Gecko is not actively working on this project anymore, but some last commit about this, please?

@lord-kyron commented on GitHub (Jul 27, 2020): @Real-Gecko @catborise - can you make some last tries to implement this :( I know @Real-Gecko is not actively working on this project anymore, but some last commit about this, please?

kerem commented

2026-02-27 15:57:51 +03:00

Author

Owner

@Real-Gecko commented on GitHub (Oct 8, 2020):

Check out discord chat.

@Real-Gecko commented on GitHub (Oct 8, 2020): Check out discord chat.

kerem commented

2026-02-27 15:57:51 +03:00

Author

Owner

@lord-kyron commented on GitHub (Oct 9, 2020):

Working as expected on first test. Please, create PR to the master repo so that it can be merged. Thanks!

@lord-kyron commented on GitHub (Oct 9, 2020): Working as expected on first test. Please, create PR to the master repo so that it can be merged. Thanks!

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@lord-kyron commented on GitHub (Oct 12, 2020):

@catborise why did you reopened this? Not working as exoected or it needs some additional changes?

@lord-kyron commented on GitHub (Oct 12, 2020): @catborise why did you reopened this? Not working as exoected or it needs some additional changes?

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@catborise commented on GitHub (Oct 13, 2020):

before login, if you activate it you cannot login. may be it should be fixed. may be it could activate after login admin account.

@catborise commented on GitHub (Oct 13, 2020): before login, if you activate it you cannot login. may be it should be fixed. may be it could activate after login admin account.

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@lord-kyron commented on GitHub (Oct 13, 2020):

That is what I asked @Real-Gecko - can one of you guys make it possible to activate it the settings.py, but this to activate only the option to enable it in the admin settings. Like if you say enable=true - to have an option in the admin panel. If you say enable=false this option will not be present there. But if you will enable or disable it in admin this will actually turn it on or off.

@lord-kyron commented on GitHub (Oct 13, 2020): That is what I asked @Real-Gecko - can one of you guys make it possible to activate it the settings.py, but this to activate only the option to enable it in the admin settings. Like if you say enable=true - to have an option in the admin panel. If you say enable=false this option will not be present there. But if you will enable or disable it in admin this will actually turn it on or off.

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@Real-Gecko commented on GitHub (Oct 13, 2020):

Solution is obvious: disable in settings.py, login, grab qr code, enable in settings.py. If we put the option inside admin interface you can easily end in scenario like this: you enable, log out without qr and that's it, you cannot disable OTP now without connecting to your database, which requires a little bit more than writing vi settings.py.

Like if you say enable=true - to have an option in the admin panel. If you say enable=false this option will not be present there.

But it's basically the same, if you're locked out you'll need to edit settings.py which is the same as it is now.

@Real-Gecko commented on GitHub (Oct 13, 2020): Solution is obvious: disable in `settings.py`, login, grab qr code, enable in `settings.py`. If we put the option inside admin interface you can easily end in scenario like this: you enable, log out without qr and that's it, you cannot disable OTP now without connecting to your database, which requires a little bit more than writing `vi settings.py`. > Like if you say enable=true - to have an option in the admin panel. If you say enable=false this option will not be present there. But it's basically the same, if you're locked out you'll need to edit `settings.py` which is the same as it is now.

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@lord-kyron commented on GitHub (Oct 13, 2020):

Solution is obvious: disable in settings.py, login, grab qr code, enable in settings.py. If we put the option inside admin interface you can easily end in scenario like this: you enable, log out without qr and that's it, you cannot disable OTP now without connecting to your database, which requires a little bit more than writing vi settings.py.

Like if you say enable=true - to have an option in the admin panel. If you say enable=false this option will not be present there.

But it's basically the same, if you're locked out you'll need to edit settings.py which is the same as it is now.

This is true actually. @catborise ?

@lord-kyron commented on GitHub (Oct 13, 2020): > Solution is obvious: disable in `settings.py`, login, grab qr code, enable in `settings.py`. If we put the option inside admin interface you can easily end in scenario like this: you enable, log out without qr and that's it, you cannot disable OTP now without connecting to your database, which requires a little bit more than writing `vi settings.py`. > > > Like if you say enable=true - to have an option in the admin panel. If you say enable=false this option will not be present there. > > But it's basically the same, if you're locked out you'll need to edit `settings.py` which is the same as it is now. This is true actually. @catborise ?

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@lord-kyron commented on GitHub (Oct 16, 2020):

@catborise - are you going to offer some fix or this approach is sufficient?

@lord-kyron commented on GitHub (Oct 16, 2020): @catborise - are you going to offer some fix or this approach is sufficient?

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@catborise commented on GitHub (Oct 16, 2020):

i think it is enough for now. the other solution is nice but there is too overhead.

@catborise commented on GitHub (Oct 16, 2020): i think it is enough for now. the other solution is nice but there is too overhead.

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@Real-Gecko commented on GitHub (Oct 16, 2020):

I actually have an idea how to improve current functionality, will implement it soon.

@Real-Gecko commented on GitHub (Oct 16, 2020): I actually have an idea how to improve current functionality, will implement it soon.

kerem commented

2026-02-27 15:57:52 +03:00

Author

Owner

@lord-kyron commented on GitHub (Oct 16, 2020):

I am re-opening the issue again then @Real-Gecko

@lord-kyron commented on GitHub (Oct 16, 2020): I am re-opening the issue again then @Real-Gecko

kerem referenced this issue

2026-02-27 15:58:48 +03:00

[PR #220] [MERGED] fix for dhcp fixed address #461