starred/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud.git synced 2026-04-25 15:35:57 +03:00
Code Issues 199 Projects Releases 1 Packages Wiki Activity

[GH-ISSUE #199] feature request: change color of expanded "create instance" button type #133

New issue
Closed
opened 2026-02-27 15:57:27 +03:00 by kerem · 7 comments
kerem commented 2026-02-27 15:57:27 +03:00
Owner
Copy link

Originally created by @lord-kyron on GitHub (Oct 19, 2018).
Original GitHub issue: https://github.com/retspen/webvirtcloud/issues/199

@catborise @honza801
You know when you hit the green + button on the Instance page and choose a compute host, you are being dropped in the create new instance page.
On the top there are 3 buttons - Custom, Template and XML. When you click on some of those buttons, the are actually expanding, but nothing is suggesting that you can click back on the same button and collapse the fill-in form which was opened.
The collapsed button color is green - can you make it when you click on some button and it is in expanded state, this button to become red, so that it can suggest to click you back to exit from this particular form?
It would be great, thanks!
In those example pictures below, I've opened the Custom button, but nothing suggests it is exactly it which is opened.
image
image

Originally created by @lord-kyron on GitHub (Oct 19, 2018). Original GitHub issue: https://github.com/retspen/webvirtcloud/issues/199 @catborise @honza801 You know when you hit the green + button on the Instance page and choose a compute host, you are being dropped in the create new instance page. On the top there are 3 buttons - Custom, Template and XML. When you click on some of those buttons, the are actually expanding, but nothing is suggesting that you can click back on the same button and collapse the fill-in form which was opened. The collapsed button color is green - can you make it when you click on some button and it is in expanded state, this button to become red, so that it can suggest to click you back to exit from this particular form? It would be great, thanks! In those example pictures below, I've opened the Custom button, but nothing suggests it is exactly it which is opened. ![image](https://user-images.githubusercontent.com/39150122/47239871-2d923080-d3ef-11e8-9a99-b902f417e3d4.png) ![image](https://user-images.githubusercontent.com/39150122/47239906-4a2e6880-d3ef-11e8-82f3-2145b68fb650.png)
kerem closed this issue 2026-02-27 15:57:28 +03:00
kerem commented 2026-02-27 15:57:28 +03:00
Author
Owner
Copy link

@catborise commented on GitHub (Oct 22, 2018):

i dont know very well javascript but i can convert it to accordion which opens only one at a time...

<!-- gh-comment-id:431844932 --> @catborise commented on GitHub (Oct 22, 2018): i dont know very well javascript but i can convert it to accordion which opens only one at a time...
kerem commented 2026-02-27 15:57:28 +03:00
Author
Owner
Copy link

@lord-kyron commented on GitHub (Oct 22, 2018):

yes this can help. Can you make such change in some branch so that I can give it a try and see if it is good enough to use it please?

<!-- gh-comment-id:431880943 --> @lord-kyron commented on GitHub (Oct 22, 2018): yes this can help. Can you make such change in some branch so that I can give it a try and see if it is good enough to use it please?
kerem commented 2026-02-27 15:57:28 +03:00
Author
Owner
Copy link

@lord-kyron commented on GitHub (Oct 22, 2018):

or maybe @honza801 can help with the java?

<!-- gh-comment-id:431913685 --> @lord-kyron commented on GitHub (Oct 22, 2018): or maybe @honza801 can help with the java?
kerem commented 2026-02-27 15:57:28 +03:00
Author
Owner
Copy link

@honza801 commented on GitHub (Oct 23, 2018):

hmm, maybe there should be tabs, not collapsed divs... ?

<!-- gh-comment-id:432122905 --> @honza801 commented on GitHub (Oct 23, 2018): hmm, maybe there should be tabs, not collapsed divs... ?
kerem commented 2026-02-27 15:57:28 +03:00
Author
Owner
Copy link

@lord-kyron commented on GitHub (Oct 23, 2018):

I personally think tabs will be the best solution. I just suggested something I thought will be simple.

<!-- gh-comment-id:432124487 --> @lord-kyron commented on GitHub (Oct 23, 2018): I personally think tabs will be the best solution. I just suggested something I thought will be simple.
kerem commented 2026-02-27 15:57:28 +03:00
Author
Owner
Copy link

@honza801 commented on GitHub (Oct 23, 2018):

try this commit/branch
https://github.com/honza801/webvirtcloud/tree/new_instance_tabs

<!-- gh-comment-id:432147915 --> @honza801 commented on GitHub (Oct 23, 2018): try this commit/branch https://github.com/honza801/webvirtcloud/tree/new_instance_tabs
kerem commented 2026-02-27 15:57:28 +03:00
Author
Owner
Copy link

@lord-kyron commented on GitHub (Oct 23, 2018):

I added comment there with some screenshots. It seems to me that it is not working as expected :)
Unless you were expecting it to work just way I described in the comment there.

<!-- gh-comment-id:432208090 --> @lord-kyron commented on GitHub (Oct 23, 2018): I added comment there with some screenshots. It seems to me that it is not working as expected :) Unless you were expecting it to work just way I described in the comment there.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v1.0
Labels
Clear labels   
bug

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/webvirtcloud#133
No description provided.