[PR #73] Full Support For Environment Proxy (http, https, no_proxy) #199

New issue

Open

opened 2026-03-01 18:44:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:44:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/webapp/pull/73
Author: @Mionsz
Created: 8/10/2024
Status: 🔄 Open

Base: master ← Head: private/mlinkiew/fetch_master

📝 Commits (4)

d8f568b Reflecting Dockerfile-netbootxyz changes
88f97d5 HTTP and HTTPS proxy agents added
c908234 Dockerfile code improvements and labeles added.
ff5ed14 Merge branch 'master' into private/mlinkiew/fetch_master

📊 Changes

7 files changed (+146 additions, -101 deletions)

View changed files

📝 Dockerfile (+24 -9)
📝 app.js (+47 -13)
📝 package.json (+4 -1)
📝 root/defaults/default (+1 -1)
📝 root/etc/supervisor.conf (+3 -3)
➕ root/init.sh (+65 -0)
📝 root/start.sh (+2 -74)

📄 Description

Full http_proxy https_proxy, no_proxy suupport:

Support for http_proxy, https_proxyh and no_proxy environment variables implemented. This include reading variables from process environment, comparing request_url with no_proxy cidr's and names, and of course setting and redirecting requests using proxy or corporate proxy services. This does not impact by any means the DHCP and TFTP services - only webapp.

Environments read for comparision:

http_proxy || HTTP_PROXY
https_proxt || HTTPS_PROXY
no_proxy || NO_PROXY

Implemented and/or extended:

DownloaderHelper.
Socket fetch.
Devgetbrowser method.

One method for each approach getProxyAgentFromUrl().
Almost no changes to the code are needed.

This fully resolves: https://github.com/netbootxyz/webapp/issues/66

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/webapp/pull/73 **Author:** [@Mionsz](https://github.com/Mionsz) **Created:** 8/10/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `private/mlinkiew/fetch_master` --- ### 📝 Commits (4) - [`d8f568b`](https://github.com/netbootxyz/webapp/commit/d8f568b1bcaa60c5345dce61b6cfc46cd178f408) Reflecting Dockerfile-netbootxyz changes - [`88f97d5`](https://github.com/netbootxyz/webapp/commit/88f97d503c4477f06112f932992ccdeaf207cdb2) HTTP and HTTPS proxy agents added - [`c908234`](https://github.com/netbootxyz/webapp/commit/c90823481e0230edf7ff0e4a1941b015f7633f9d) Dockerfile code improvements and labeles added. - [`ff5ed14`](https://github.com/netbootxyz/webapp/commit/ff5ed145c547e0b5c5dcac0a97c9cf908f496298) Merge branch 'master' into private/mlinkiew/fetch_master ### 📊 Changes **7 files changed** (+146 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `Dockerfile` (+24 -9) 📝 `app.js` (+47 -13) 📝 `package.json` (+4 -1) 📝 `root/defaults/default` (+1 -1) 📝 `root/etc/supervisor.conf` (+3 -3) ➕ `root/init.sh` (+65 -0) 📝 `root/start.sh` (+2 -74) </details> ### 📄 Description ### Full http_proxy https_proxy, no_proxy suupport: Support for http_proxy, https_proxyh and no_proxy environment variables implemented. This include reading variables from process environment, comparing request_url with no_proxy cidr's and names, and of course setting and redirecting requests using proxy or corporate proxy services. This does not impact by any means the DHCP and TFTP services - only webapp. Environments read for comparision: - `http_proxy` || `HTTP_PROXY` - `https_proxt` || `HTTPS_PROXY` - `no_proxy` || `NO_PROXY` Implemented and/or extended: - DownloaderHelper. - Socket fetch. - Devgetbrowser method. One method for each approach getProxyAgentFromUrl(). Almost no changes to the code are needed. This fully resolves: https://github.com/netbootxyz/webapp/issues/66 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>