mirror of
https://github.com/matze/wastebin.git
synced 2026-04-25 08:36:00 +03:00
[GH-ISSUE #60] Would you be open to a PR changing from grid layout to flexbox layout? #48
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/wastebin-matze#48
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @kshannoninnes on GitHub (Jun 28, 2024).
Original GitHub issue: https://github.com/matze/wastebin/issues/60
Love the minimalist style, but it's bothering me that the content div is overflowing and creating a scrollbar. I've looked through the stylesheet a bit and played around, and I believe the cause is due to the way the grid layout is used (although I'm not 100% on this).
If you prefer to stay with the grid style, that's cool. I'll keep my forked version for my own usage.
@matze commented on GitHub (Jun 28, 2024):
Do you have some example how you would like to have it? Not sure what the layout change would look like.
@kshannoninnes commented on GitHub (Jun 29, 2024):
On further investigation I believe the scrollbar is actually mostly due to the way you've implemented the select box for languages. I'm not sure if there's a way to apply a dynamic size in this case, as 23 (with the spacing between elements in that right-menu) is too large and introduces a page scrollbar (screenshot below).
I think there are a couple potential ways of solving my issue.
I don't think any of the suggestions are good ones. It might be best for me to just keep a forked version for myself? Open to ideas. I've included a screenshot of the second option of changes that I implemented on my own copy below (ignore the random artifacts in the bottom right, that's the old screenshot behind it in paint).
Here's a link to my fork commit for the changes that achieve the second screenshot:
github.com/kshannoninnes/wastebin@238e53d5fc@matze commented on GitHub (Jun 29, 2024):
I'm fine reducing the size again. In fact the list used to be shorter.
@matze commented on GitHub (Jun 30, 2024):
This can be closed then, right?
@matze commented on GitHub (Jan 14, 2025):
masternow is fully based on flexbox, closing this one now.