mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #1399] users.equivalent_domains field is cleartext in the database #939
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#939
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jtackaberry on GitHub (Feb 17, 2021).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/1399
Subject of the issue
users.equivalent_domainsis cleartext in the database which could leak information about sites users visit (under the assumption that users will enter domains here that they visit).Your environment
Expected behaviour
The field should be encrypted and opaque to the admin, or if this data is required to be cleartext for some backend functionality to work, that should be documented somewhere, and ideally there should be a big warning box on the front end where this is configured saying this information shouldn't be considered private.
(Though as the web client isn't your code I'm not sure if this is feasible, but it's certainly preferable of possible.)
Actual behaviour
The field is stored in plaintext and users would incorrectly assume, given the rest of Bitwarden's security posture, that anything they enter there would be encrypted on the backend.
@BlackDex commented on GitHub (Feb 17, 2021):
I don't know if that would help that much. If a user has favicon enabled this exposes that same information.
If you want to avoid this, then you are probably better off by just adding those domains to the specific ciphers as an add URL.
Also, this is something upstream doesn't encrypt either, else they would have encrypted it before sending it to the backend server.
@jtackaberry commented on GitHub (Feb 17, 2021):
@BlackDex yeah, I assumed upstream wouldn't have encrypted this either as obviously the protocol itself has this information passed in the clear.
One of the big differences between this and the favicons feature is that the latter is documented that it has privacy implications, and takes you to a page explaining what they are.
Again I know the frontend is entirely different, but in case you have some latitude as to what's displayed, or at the very least documenting it somewhere -- or perhaps this very issue will serve as that documentation (because I searched before I opened it :)).
@jjlin commented on GitHub (Feb 17, 2021):
It would be better to request this at https://community.bitwarden.com/c/feature-requests/5 so any changes benefit all Bitwarden users.