mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #1196] Handle spaces in unquoted env variables #844
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#844
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @xoxys on GitHub (Oct 21, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/1196
Subject of the issue
Spaces in an unquoted env variable value will stop processing every following env var which may result in various errors.
Your environment
Steps to reproduce
Add a space to an env var value:
Check the loaded values in the admin dashboard. All settings after
SMTP_FROM_NAMEwill not be applied anymore. Quoting the value will fix the issue e.g.SMTP_FROM_NAME="Bitwarden RS".Expected behaviour
Some kind of improved error handling. Add a variable parsing error message to the log, or fix it automatically and strip off everything after a space. Maybe we could still have a warning in the logs that var
EXAMPLEwas stripped.