mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[GH-ISSUE #1191] App immediately crashes after unlocking vault #840
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#840
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @reydus on GitHub (Oct 19, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/1191
Subject of the issue
When unlocking the vault, once you have logged in, you type your master password, and after hitting the button, it immediately crashes.
This is very similar if not identical to issue #1169, however it didn't get solved after updating both the app and the server.
Your environment
Steps to reproduce
Log in as normal
Lock the vault
Input the CORRECT master password and hit button.
Expected behaviour
The main screen with the vault content shows up.
*If a wrong password is inserted, it will say wrong password.
Actual behaviour
it immediately crashes (it goes to home screen for me, no messages)
Relevant logs
Here's a adb logcat:
@v-willems commented on GitHub (Oct 19, 2020):
On the latest raspberry pi version, I had the same issue, but with every client. I updated to latest, which fixed it with each client (Chrome-, Safari-extensions, MacOS App, iOS-App) but the android one. Surprisingly, biometrical (re-)login works just fine.
As a workaround, you might want to use this method for now.
@reydus commented on GitHub (Oct 20, 2020):
I built from source the original bitwarden mobile repo to see if I could debug it and find a line or something. But the error did not happen in this version. I will compare both the built and the Play Store version.
@nextlogic-ono commented on GitHub (Oct 22, 2020):
You have to logout and login again than just retyping password which is slightly inconvenient but can avoid the crash for now.
Fingerprint unlocking works fine though.
@BlackDex commented on GitHub (Oct 22, 2020):
Which version of the android client are you using?
@nextlogic-ono commented on GitHub (Oct 23, 2020):
I'm using the newest client at the moment which is
2.6.1 (3178).This happened on both Pixel 4a (Android 11) and Galaxy S10 (Android 10).
I've pulled the
bitwardenrs/server:latestimage now but it's still happening.@nextlogic-ono commented on GitHub (Oct 23, 2020):
This is also happening on macOS (10.15.7).
I'm using
Edge 86.0.622.48with the official Bitwarden extension version1.46.2which are both the newest versions at this point.Whenever the vault gets locked and it used to unlock fine by just typing the password but now I have to logout and login again as it says "Invalid master password", though I'm typing in the right one but it's not crashing anything for macOS.
@BlackDex commented on GitHub (Oct 23, 2020):
@windware-ono, how did you install bitwarden? Plain docker or docker compose? Did you also restart your reverse proxy after the update.
Can you also please verify via the admin interface that the right version is installed?
I'm using the android version 3226, which is a bit newer and i can't reproduce this at all.
Also, what do you see in your logs? What request is coming in at bitwarden.
@potvinp commented on GitHub (Oct 24, 2020):
I'm currently having this same issue with the Bitwarden mobile app on iOS 14.0.1. Server and web versions are up-to-date (1.17.0 for server and 2.16.1 for web) according to the /admin/diagnostics page, and the date and time matches as well. Installed via docker-compose. When running the
docker pull bitwardenrs/server:latestcommand, Docker says that the image is up-to-date. The Bitwarden mobile app on my iPhone XS is running version 2.6.1, which appears to be the latest version on the App Store.When logging in via the mobile app, the following entry shows up in the server's logs:
[2020-10-24 20:22:16.778][rustls::msgs::handshake][WARN] Illegal SNI hostname received [50, 48, 57, 46, 49, 52, 49, 46, 52, 50, 46, 49, 56, 55]I'm unsure if this is an issue caused by the server or the client, but I can login without issues in Google Chrome with the extension running on MacOS and on Windows.
@nextlogic-ono commented on GitHub (Oct 27, 2020):
I installed it via docker-compose.
I haven't changed the reverse proxy's setting but I just restarted it but no change.
Where do I find the bitwarden_rs version? I saw it says
2.14.0in the footer, but I assume this is actual Bitwarden's version that's being used.I can't see any newer version than 2.6.1 at the Play Store, so I'm at 3178.
Say, I have the Android Bitwarden app at the unlocked state, and if I go to
Lock Nowin the settings, it locks me out and if I type in the password to unlock, it crashes but the server doesn't see any new logs.If I logout and login again using the password, the server sees new log entries and it succeeds. Like said above, using the fingerprint to unlock after locking works fine but no new logs at the server for this as well.
It's the same for macOS, except the browser extension doesn't have fingerprint unlock feature.
So, it does sound like it's the client's problem when it crashes without contacting the server but I don't have knowledge of the internal working mechanism to be sure.
@Office-Monkey commented on GitHub (Oct 28, 2020):
I was afflicted by this for the last few days on Android. I was able to workaround it by: updating my server build (it was overdue) AND clearing both cache and data for the application (uninstall/reinstall might also work?). Hope this might help someone else.
@BlackDex commented on GitHub (Nov 18, 2020):
@reydus were you able to solve this issue using the provided comments and updating your server and maybe by clearing the cache of the mobile application?
@nwallace commented on GitHub (Dec 2, 2020):
I had the same issue happening on iOS. Turns out I had some bad data other clients handled fine, but the phone didn't. In my case, I had a Login URI whose URI was
null.To find the borked data, I whipped up a Ruby script to help:
You can scan the output manually to find fields that don't sound like they should be
null, or use various other tools to help out. I did this to help me see and ignore the fields that are normally null:@Starfiresg1 commented on GitHub (Dec 16, 2020):
I had the same issue on both my android devices.
The following procedure fixed it for me:
Updating my docker to the latest version (this alone didn't fix it)
Logging out of the vault on the Android App and logging back in (accessible through the 3 dots in the corner on the unlocking page)
After that I can unlock a locked vault without crash
Seems to me that the crash on unlocking is maybe created by the initial login with an older Bitwarden_rs version, because after the server update the issue still persisted until I logged in fresh.
@kenan435 commented on GitHub (Dec 18, 2020):
But that does not explain why logging in via biometrics works. I'd rather say that it happens while the master phrase is being validated.
@BlackDex commented on GitHub (Dec 18, 2020):
It is because in the code of the client the master-password entered to unlock is verified at the server side.
But that wasn't available on the older versions of bitwarden_rs. Bio-Unlock bypasses this, because it doesn't have to verify the master-password. Maybe the client caches the 404 result, and just ignores a new request or something?
@daniellandau commented on GitHub (Jan 2, 2021):
For me it got fixed exactly as @Starfiresg1 described.
@BlackDex commented on GitHub (Jan 29, 2021):
@nwallace, maybe a bit late. But a Uri as also Uris can definitely be
null. What I'm curious about is, if for that same cipher if it at one place had uri or uris filled and not at the other. Or has uris filled but not uri. Do you still remember that?@BlackDex commented on GitHub (Jan 31, 2021):
Converting this issue to a discussion.