mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[GH-ISSUE #1174] bitwarden restarting changes duo back to enable: false #828
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#828
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @shanehughes1990 on GitHub (Oct 6, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/1174
Good afternoon, Not sure this is a bug maybe just a missed config on my part, We have duo setup works flawlessly the whole bitwardenrs installation has gone by flawlessly, My only issue is whenever the docker container restarts the Duo settings in /admin get reset to enabled: false (the ikey skey and host all persist). I suppose the question is, is there a DUO_ENABLED environment variable I need to use to persist that setting? I did not see one in https://github.com/dani-garcia/bitwarden_rs/blob/master/.env.template
I also noticed there is no config.json in /data inside the container once running. I'm pretty sure that's because its the mysql variant, correct me if I am wrong?
If you are unfamiliar with kubernetes you can basically ignore everything in the following deployment file except for the container {} chunk.
Your environment
We are running kubernetes 1.18.X in gcp.
Bitwarden rs is bitwardenrs/server-mysql:1.16.3
Deployed using terraform
The following the the terraform deployment file
Steps to reproduce
Suppose the easiest way would be to deploy via docker compose and add the mysql & duo environment variables
Expected behaviour
Duo enabled: true
Actual behaviour
Upon start/restart Duo setting in /admin changes from enabled: true to enabled: false
Relevant logs
@shanehughes1990 commented on GitHub (Oct 6, 2020):
Sorry quick update was just doing some testing, it appears the config.json file gets created only IF I change something in /admin, So I can import a config.json I think to get around my issue would be better if there was just an environment variable to enable it though
@jjlin commented on GitHub (Oct 6, 2020):
If you hover over the config item, you can see the item name (
_enable_duoin this case), then uppercase it for the env var name:_ENABLE_DUO@shanehughes1990 commented on GitHub (Oct 6, 2020):
Oh that's wonderful thank you very much, This I presume is this way for ANY env listed in config.json?
@BlackDex commented on GitHub (Oct 6, 2020):
If this is a user toggle, then i think we actually need to remove the _ in my opinion. Since all _ vars should not changeable via env i think
@shanehughes1990 commented on GitHub (Oct 6, 2020):
Why not? this would mean I would need a config.json to enable duo on start would it not?
@BlackDex commented on GitHub (Oct 6, 2020):
No, it means the exact opposite. In my opinion vars starting with an _ should not be user editable. So i think we need to change that var to not have an _.
The reason is, there are a few of those _ vars which could cause issues if users can change them i think.
@shanehughes1990 commented on GitHub (Oct 6, 2020):
Yeah I read it again and realized what it was you were saying :P, FWY fix worked flawlessly its officially ready for me to move release it to our employees :) so thanks for everyone's help