mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[GH-ISSUE #1164] Changing KDF iterations breaks logged in clients #821
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#821
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @julian-klode on GitHub (Sep 29, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/1164
Subject of the issue
Changing number KDF iterations breaks logged in clients. They should be logged out instead.
Your environment
Steps to reproduce
Change KDF size, then sync client or wait for corruption to appear automatically.
Expected behaviour
Seeing what bitwarden.com does: Connected clients are logged out.
Actual behaviour
Connected clients fail to read the database
Relevant logs
Not much interesting going on. I triggered a sync on mobile manually, as it apparently did not get a push.
@BlackDex commented on GitHub (Sep 29, 2020):
Hmm, we have to deauthorize all the user sessions in this case it seems. Thanks for reporting.
Please note that we do not support push messages so that is not possible on our side.
@dani-garcia commented on GitHub (Oct 3, 2020):
This should be fixed by
github.com/dani-garcia/bitwarden_rs@448e6ac917, which invalidates users sessions when they change email, pass or kdf params.