mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[GH-ISSUE #981] Organization Two-step Login #697
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#697
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bloodypiker on GitHub (May 4, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/981
Subject of the issue
Orinizational requirement of two factor login on their personal account does not work.
Your environment
Steps to reproduce
Created a new test organization and enabled two-step login within the policies of the organization. I created a test new user without two-factor and added them to the organization.
Expected behavior
Users without two-step logins should not be able to access the stored items within the organization.
"Organization members who do not have two-step login enabled for their personal account will be removed from the organization and will receive an email notifying them about the change."
Actual behavior
Users of all access levels (owner, admin, manager, user) can access all items stored within the org. without satisfying the org. two-factor policy.
If the user had two-factor but removed it, email is not sent nor do they lose access to the org.
Relevant logs
@dani-garcia commented on GitHub (May 7, 2020):
Yes at the moment the policies are only handled client side, but we should handle the 2FA one server side too.
Is the procedure you mention what the official server does? The letting the user remove the second factor, sending them and email and removing their access, I mean.
My initial idea was to simply not let them remove the 2FA if they are part of such an organization, but if upstream does it that way maybe we should follow their steps.
@bloodypiker commented on GitHub (May 8, 2020):
Unfortunately, I have not interfaced with the official server offer.
From the official help documents:
@fourstepper commented on GitHub (Dec 8, 2020):
If I understand correctly, right now there is no way to enforce the use of in orgs 2FA from the bitwarden_rs server?
@omueller commented on GitHub (Jan 7, 2021):
Hi @fourstepper, have you found new information about that issue in the mean time ? I have the same problem, and at the moment, when I create a new company user, I need to:
It would be great if there was a way to skip step 3 (and also 4, but it seems there is no other way around?).
Of course these are small issues, thanks again @dani-garcia for your great work!
Best regards, Olivier
@fourstepper commented on GitHub (Jan 7, 2021):
Hi Olivier,
There was no change for me in this regard - this still seems like it's unavailable.
@olivierIllogika commented on GitHub (Apr 12, 2021):
Hi,
Just created a pull request for this. It's my first time coding rust, but it seems to get the job done.
Please test and give feedback.
Thanks!