mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #969] SMTP_FROM_NAME not working #688
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#688
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @duffycop on GitHub (Apr 16, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/969
SMTP_FROM_NAME isn't working
In the last version of the Docker image the environment variable SMTP_FROM_NAME isn't working.
By taking a look at the source code I was able to identify the issue in the line 388 of src/config.rs
smtp_from_name: String, true, def, "Bitwarden_RS".to_string();
Maybe this should be as line 386 where the definition is
smtp_from: String, true, def, String::new();
So modified line 388 would be like this
smtp_from_name: String, true, def, String::new();
EDIT: I didn't tested the environment: tag in the docker-compose.yml file.
My docker-compose.yml look like this
Thanks for your time! And you've done an amazing work here!
Best regards!
@jjlin commented on GitHub (Apr 16, 2020):
SMTP_FROMandSMTP_FROM_NAMEare different config items with distinct purposes. You probably have a config.json that's overriding your env var. Take a look at https://github.com/dani-garcia/bitwarden_rs/wiki/Configuration-overview.