mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-25 17:25:57 +03:00
[GH-ISSUE #936] Impossible to delete user if it is the only owner of an organization #662
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#662
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @spudjb on GitHub (Mar 29, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/936
Subject of the issue
If a user exists who created an organization that they are the only owner of, it is impossible to delete them.
Your environment
Steps to reproduce
Expected behaviour
It should be possible to delete this user, or at least prevent future logins somehow. Alternatively, users should be prevented from creating organizations.
Actual behaviour
The user could not be deleted with the following error message:
Relevant logs
@dani-garcia commented on GitHub (Mar 30, 2020):
Hmm, for this we need to do two things I think:
When trying to delete a user that's the last owner from the admin page, we should detect the error and offer to also delete the organization. This could just be a dialog after the delete user confim dialog.
On the other side, we should also allow one way to promote a different user to owner, in case we want to keep the organization in place. We can't make another user join, because that would require access for the crypto keys, but we can change a users organization level, probably by clicking on the organization name from the user entry in the admin page, we could show a dialog there to switch users level.
@spudjb commented on GitHub (Mar 30, 2020):
I think it would be best to offer both:
possible?)
Then these could be used to clean up the situation prior to removing the
user.
On Mon, Mar 30, 2020, 22:00 Daniel García notifications@github.com wrote:
@jjlin commented on GitHub (Mar 31, 2020):
It might make sense to do this by implementing the relevant pieces of the Bitwarden public API (https://docs.bitwarden.com/), which could be the foundation of a full implementation later on.
@speedygonzales391 commented on GitHub (Oct 16, 2020):
Any progress about this?
@BlackDex commented on GitHub (Feb 3, 2021):
I'm currently working on a way to change a user-type from the users/overview page.
That way you can at least promote an other user to admin if that user is already a member of that same organization.
And i'm adding a delete org on the organization overview page.
I find it tricky to offer a new dialog asking to delete the org also if that users is the last owner.
I'm afraid that people will quickly press yes, yes, yes even if we add extra
are you sure toodialog boxes.People just do not read. Therefore i will add it to the org overview where it will be clear to delete an org and not a user.