mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[GH-ISSUE #908] Import (1pif) into organization broken #648
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#648
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @paradeiser on GitHub (Mar 15, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/908
Since the latest update to 2.13.1 Bitwarden crashes when trying to import a .1pif file.
Steps to reproduce
When using the Import page in the web UI, I select .1pif and upload the file.
After a few seconds bitwarden reloads with the login page, stating an unexpected failiure and I have to relogin.
Before the update I frequently used this option without issues.
Is it just me?
best regards
@jjlin commented on GitHub (Mar 16, 2020):
It would help if you could try your import on vault.bitwarden.com to determine whether the issue originates upstream.
@paradeiser commented on GitHub (Mar 16, 2020):
this is bitwarden_rs for selfhosted instances. so I dont have access to vault.bitwarden.com
@jjlin commented on GitHub (Mar 16, 2020):
Most bitwarden_rs users don't use 1Password, so if you're interested in making progress on this issue, it would be helpful if you tried your import on vault.bitwarden.com, as the bitwarden_rs web vault is almost identical to the upstream web vault, and I don't know of any reason 1Password imports would be broken on bitwarden_rs specifically. If your issue also happens on the upstream vault, then an issue should be raised there instead.
@paradeiser commented on GitHub (Mar 16, 2020):
I tried to trace it down:
hope that helps to trace down the bug.
best regards
@BlackDex commented on GitHub (Mar 18, 2020):
@paradeiser are you able to create a test export for us?
I don't have 1Password, and i think most of developers here do not have that, since they use bitwarden ;).
Also, i noticed at the official documentation that there are two different versions/ways to export/import it into bitwarden: https://help.bitwarden.com/article/import-from-1password/
But in any case, an example export would be cool to have so that we can test it.
@paradeiser commented on GitHub (Mar 18, 2020):
sure, here you go:
1Password_TestExportFile.1pif.zip
(zipped coz otherwise not supported to upload here)
@BlackDex commented on GitHub (Mar 18, 2020):
Great! Thx. Lets see what we can find.
@kidfrostbite commented on GitHub (Mar 18, 2020):
Fwiw I'm having the same issue and can supply more info and logs if needed. The import also fails for me with json data. I even tried a most basic test of creating a new org, making one test entry in the org's vault, exporting that as bitwarden .json and the same failure occurs. Relevant log entries are:
2020-03-17 18:50:19][auth][ERROR] Unauthorized Error: The current user isn’t member of the organization
[2020-03-17 18:50:19][response][INFO] POST /api/ciphers/import-organization?<query…> (post_org_import) => 401 Unauthorized
I've also verified that everything works as expected on vault.bitwarden.com.
@BlackDex commented on GitHub (Mar 18, 2020):
I can verify this also.
Now to find out why.
@karrots commented on GitHub (Mar 19, 2020):
Seeing this same issue with a KeePass XML import. It has a fair amount of folders which would be imported as collections. A few of the collections already exist.
@BlackDex commented on GitHub (Mar 19, 2020):
@karrots, this is with all imports in to the organization. Not specifically linked to a specific kind of import
@karrots commented on GitHub (Mar 19, 2020):
ok cool. Is there a build of the dockers that follows master? I'd love to test this fix.
@BlackDex commented on GitHub (Mar 19, 2020):
The bitwardenrs/server:latest is the one to look for. It does take a while for them to build, so we all have to be a bit patient unfortunately. The fix will be in the version with this hash part ff19fb.
@karrots commented on GitHub (Mar 19, 2020):
This commit fixed the problem for me.
@kidfrostbite commented on GitHub (Mar 20, 2020):
Fixed for me as well.
@dani-garcia commented on GitHub (Mar 21, 2020):
Great! The latest release 1.14.1 contains this fix, it'll take some time to build the docker images still.