mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[GH-ISSUE #891] Download icon create panic #636
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#636
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomamplius on GitHub (Mar 3, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/891
After migration to bitwarden_rs version 13
The service crash when i'm login bitwarden_rs
@dani-garcia commented on GitHub (Mar 3, 2020):
Does this happen with a new account if you add a couple of password entries, with URL? The stackstrace doesn't contain very useful information so we'd have to know what domain name icon is making the server crash
@tomamplius commented on GitHub (Mar 3, 2020):
Sorry i have 2 url before the issue without "200 OK"
[request][INFO] GET /icons/www.ag2rlamondiale.fr/icon.png
[request][INFO] GET /icons/epargnants.interepargne.natixis.fr/icon.png
But retrieving icons can be a non-blocking error?
@tomamplius commented on GitHub (Mar 3, 2020):
After many restart, with crash whan i'm login.
I can now login without crash.
If you want, you can close the issue.
But i can help you if you want understand this issue.
I mean that icons cache was clean on my last upgrade?
It is not the first time that I encounter this problem with the same solution for icons (crash until it's work)
@BlackDex commented on GitHub (Mar 4, 2020):
Well, i tried both urls to download the icons reported earlier. But those do not trigger an error.
I don't know if you have a lot of icons, or of you are willing to share the urls since that could be a privacy/security concern.
One way to test it, is by deleting those cached icons from the icon_cache folder one by one and reload the page. Or maybe multiple to speed it a bit up, but max 5 else it would be getting difficult.
I can try and create a small bash script which could try and automat it if you can access the icon_cache folder from a linux cli/shell.
Or maybe share the list of urls privately via the matrix chat?
@tomamplius commented on GitHub (Mar 5, 2020):
I have delete all file in /opt/bitwarden/data/icon_cache/
I can't reproduce
I can send you log file on Matrix @thomas:lgy.fr
@BlackDex commented on GitHub (Mar 5, 2020):
@tomamplius I have contacted you via matrix :).
@tomamplius commented on GitHub (Mar 5, 2020):
I Can't reproduce
Close and re-open if needed
@dani-garcia Thanks a lot for your work to you and others project participant