[GH-ISSUE #819] Parse bool values correctly #573

New issue

Closed

opened 2026-03-03 01:30:40 +03:00 by kerem · 2 comments

kerem commented

2026-03-03 01:30:40 +03:00

Owner

Originally created by @xoxys on GitHub (Jan 18, 2020).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/819

Currently, uppercase bool values seems not to work e.g. SIGNUPS_ALLOWED=False which is really confusing and can lead to missconfigured public servers.

Normally, most common bool-ish string values like 1,0/yes,no/y,n/true,false/True,False should be converted to a real bool while reading env variables.

Originally created by @xoxys on GitHub (Jan 18, 2020). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/819 Currently, uppercase bool values seems not to work e.g. `SIGNUPS_ALLOWED=False` which is really confusing and can lead to missconfigured public servers. Normally, most common bool-ish string values like `1,0/yes,no/y,n/true,false/True,False` should be converted to a real bool while reading env variables.

kerem closed this issue

2026-03-03 01:30:40 +03:00

kerem commented

2026-03-03 01:30:41 +03:00

Author

Owner

@dani-garcia commented on GitHub (Jan 20, 2020):

Should be fixed in github.com/dani-garcia/bitwarden_rs@d212dfe735 now.

@dani-garcia commented on GitHub (Jan 20, 2020): Should be fixed in https://github.com/dani-garcia/bitwarden_rs/commit/d212dfe735e59128667a4c579e52ce7e86b53a94 now.

kerem commented

2026-03-03 01:30:41 +03:00

Author

Owner

@xoxys commented on GitHub (Jan 20, 2020):

Cool, looks nice. Thanks for the fast fix.

@xoxys commented on GitHub (Jan 20, 2020): Cool, looks nice. Thanks for the fast fix.