starred/vaultwarden
1
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-04-25 17:25:57 +03:00
Code Issues 39 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #100] PUT /api/ciphers/share not implemented #57

New issue
Closed
opened 2026-03-03 01:24:18 +03:00 by kerem · 10 comments
kerem commented 2026-03-03 01:24:18 +03:00
Owner
Copy link

Originally created by @mprasil on GitHub (Jul 21, 2018).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/100

New vault (#93) calls PUT on /api/ciphers/share to "Share selected" ciphers. This functionality wasn't present in the previous vault so implementation will be a bit more involved, but should be pretty similar to "move selected".

(also woohoo! 100th issue 😄)

Originally created by @mprasil on GitHub (Jul 21, 2018). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/100 New vault (#93) calls `PUT` on `/api/ciphers/share` to "Share selected" ciphers. This functionality wasn't present in the previous vault so implementation will be a bit more involved, but should be pretty similar to "move selected". (also woohoo! 100th issue :smile:)
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@tgturner commented on GitHub (Jul 26, 2018):

I would love to take a look at this one!

<!-- gh-comment-id:408070081 --> @tgturner commented on GitHub (Jul 26, 2018): I would love to take a look at this one!
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@mprasil commented on GitHub (Jul 26, 2018):

Go for it and don't hesitate to ask for help.

<!-- gh-comment-id:408082367 --> @mprasil commented on GitHub (Jul 26, 2018): Go for it and don't hesitate to ask for help.
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@tgturner commented on GitHub (Jul 26, 2018):

Thanks! I'll take a look at it this evening.

<!-- gh-comment-id:408102871 --> @tgturner commented on GitHub (Jul 26, 2018): Thanks! I'll take a look at it this evening.
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@krankur commented on GitHub (Aug 1, 2018):

I guess we need to add an organization in order to test the "Share" functionality, but I am not able to figure out how to add an organization? I tried uploading a random JSON file as the license file but I am getting a 401 error. Can someone please guide me on this?

<!-- gh-comment-id:409528307 --> @krankur commented on GitHub (Aug 1, 2018): I guess we need to add an organization in order to test the "Share" functionality, but I am not able to figure out how to add an organization? I tried uploading a random JSON file as the license file but I am getting a 401 error. Can someone please guide me on this?
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@mprasil commented on GitHub (Aug 1, 2018):

Hi, there's no licence required - just create free organization (the first option) and it should have all features after that.

<!-- gh-comment-id:409529384 --> @mprasil commented on GitHub (Aug 1, 2018): Hi, there's no licence required - just create free organization (the first option) and it should have all features after that.
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@dani-garcia commented on GitHub (Aug 1, 2018):

I think that happens in the self hosted version (when you build with npm run dist:selfhost)

It should work if you build the normal version (with npm run dist)

<!-- gh-comment-id:409529396 --> @dani-garcia commented on GitHub (Aug 1, 2018): I think that happens in the self hosted version (when you build with npm run dist:selfhost) It should work if you build the normal version (with npm run dist)
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@mprasil commented on GitHub (Aug 1, 2018):

@dani-garcia I submitted #109 to merge recent changes from master. We should do this before @krankur touches the sharing API as there were some major changes and will be pain to merge later.

<!-- gh-comment-id:409532194 --> @mprasil commented on GitHub (Aug 1, 2018): @dani-garcia I submitted #109 to merge recent changes from master. We should do this before @krankur touches the sharing API as there were some major changes and will be pain to merge later.
kerem commented 2026-03-03 01:24:20 +03:00
Author
Owner
Copy link

@mprasil commented on GitHub (Aug 1, 2018):

Thanks for merging it. @krankur make sure you're working with latest beta code.

<!-- gh-comment-id:409536730 --> @mprasil commented on GitHub (Aug 1, 2018): Thanks for merging it. @krankur make sure you're working with latest beta code.
kerem commented 2026-03-03 01:24:21 +03:00
Author
Owner
Copy link

@krankur commented on GitHub (Aug 1, 2018):

@mprasil Will do. Thanks for the heads up.

<!-- gh-comment-id:409559173 --> @krankur commented on GitHub (Aug 1, 2018): @mprasil Will do. Thanks for the heads up.
kerem commented 2026-03-03 01:24:21 +03:00
Author
Owner
Copy link

@mprasil commented on GitHub (Aug 9, 2018):

I think this was resolved in #116

<!-- gh-comment-id:411814957 --> @mprasil commented on GitHub (Aug 9, 2018): I think this was resolved in #116
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
revert-7033-patch-1
cached-config-operations
test_dylint
1.35.7
1.35.6
1.35.5
1.35.4
1.35.3
1.35.2
1.35.1
1.35.0
1.34.3
1.34.2
1.34.1
1.34.0
1.33.2
1.33.1
1.33.0
1.32.7
1.32.6
1.32.5
1.32.4
1.32.3
1.32.2
1.32.1
1.32.0
1.31.0
1.30.5
1.30.4
1.30.3
1.30.2
1.30.1
1.30.0
1.29.2
1.29.1
1.29.0
1.28.1
1.28.0
1.27.0
1.26.0
1.25.2
1.25.1
1.25.0
1.24.0
1.23.1
1.23.0
1.22.2
1.22.1
1.22.0
1.21.0
1.20.0
1.19.0
1.18.0
1.17.0
1.16.3
1.16.2
1.16.1
1.16.0
1.15.1
1.15.0
1.14.2
1.14.1
1.14
1.13.1
1.13.0
1.12.0
1.11.0
1.10.0
1.9.1
1.9.0
1.8.0
1.7.0
1.6.1
1.6.0
1.5.0
1.4.0
1.3.0
1.2.0
1.1.0
1.0.0
0.13.0
0.12.0
0.11.0
0.10.0
0.9.0
Labels
Clear labels   
SSO

   
Third party

   
better for forum

   
bug

   
bug

   
documentation

   
duplicate

   
enhancement

   
future Vault

   
future Vault

   
future Vault

   
good first issue

   
help wanted

   
low priority

   
notes

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
troubleshooting

   
wontfix
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#57
No description provided.