[GH-ISSUE #98] DELETE /api/ciphers not implemented #53

Closed
opened 2026-03-03 01:24:16 +03:00 by kerem · 7 comments
Owner

Originally created by @mprasil on GitHub (Jul 21, 2018).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/98

New vault (#93) calls DELETE on /api/ciphers to "Delete selected" ciphers. We have POST handler already implemented for this, so this should be easy to fix.

Originally created by @mprasil on GitHub (Jul 21, 2018). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/98 New vault (#93) calls `DELETE` on `/api/ciphers` to "Delete selected" ciphers. We have `POST` handler [already implemented](https://github.com/dani-garcia/bitwarden_rs/blob/48e69cebab29585684be4bf22282ff1dd4697d24/src/api/core/ciphers.rs#L465) for this, so this should be easy to fix.
Author
Owner

@mannp commented on GitHub (Jul 31, 2018):

Is the stable release of v2 tagged for the docker image at all?

Currently using the beta build to get v2, but unclear if there is another build I should be using?

Thanks

<!-- gh-comment-id:409183055 --> @mannp commented on GitHub (Jul 31, 2018): Is the stable release of v2 tagged for the docker image at all? Currently using the beta build to get v2, but unclear if there is another build I should be using? Thanks
Author
Owner

@mprasil commented on GitHub (Jul 31, 2018):

The beta image is using the 2.0.0 release of Vault, so that's the one you can use to test it.

<!-- gh-comment-id:409186689 --> @mprasil commented on GitHub (Jul 31, 2018): The beta image is using the 2.0.0 release of Vault, so that's the one you can use to test it.
Author
Owner

@mannp commented on GitHub (Jul 31, 2018):

Ok, so i updated my beta to the latest and it still doesn't delete any entries.

<!-- gh-comment-id:409213718 --> @mannp commented on GitHub (Jul 31, 2018): Ok, so i updated my beta to the latest and it still doesn't delete any entries.
Author
Owner

@mprasil commented on GitHub (Jul 31, 2018):

This is why this issue was open. 😄 It hasn't been fixed yet, I think I've confused you somewhere into thinking it's been resolved.

<!-- gh-comment-id:409214928 --> @mprasil commented on GitHub (Jul 31, 2018): This is why this issue was open. 😄 It hasn't been fixed yet, I think I've confused you somewhere into thinking it's been resolved.
Author
Owner

@mannp commented on GitHub (Jul 31, 2018):

Apologies for the noise, thought I'd seen a post saying 3 or 4 bugs were fixed, including this one and there were in a stable branch of v2.

<!-- gh-comment-id:409217806 --> @mannp commented on GitHub (Jul 31, 2018): Apologies for the noise, thought I'd seen a post saying 3 or 4 bugs were fixed, including this one and there were in a stable branch of v2.
Author
Owner

@mprasil commented on GitHub (Jul 31, 2018):

Yeah, you'll see these issues being closed once that is fixed.

<!-- gh-comment-id:409218274 --> @mprasil commented on GitHub (Jul 31, 2018): Yeah, you'll see these issues being closed once that is fixed.
Author
Owner

@mprasil commented on GitHub (Aug 6, 2018):

Resolved in #115

<!-- gh-comment-id:410679484 --> @mprasil commented on GitHub (Aug 6, 2018): Resolved in #115
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#53
No description provided.