mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[GH-ISSUE #602] Synology NAS Set PUID and PGID as Variables #402
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#402
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @newkind on GitHub (Sep 5, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/602
I'd like to kindly request a feature that would allow Synology NAS users to change the UID and GID as environment variables.
I know that there's a guide in WIKI on how to change the user to non-root but having this possiblity using environment variables would be awesome.
This is exactly the same feature request as it was made in the piHole : https://github.com/pi-hole/docker-pi-hole/issues/328
Thank you!
@mprasil commented on GitHub (Sep 6, 2019):
Can someone with synology submit a PR they've been able to verify that it works as expected? I can help making sure this does not break stuff on rest of the platforms.
@mtonnie commented on GitHub (Dec 2, 2019):
What about a native package for synology, this would propably support more models than a docker solution.
@aledexter commented on GitHub (Apr 30, 2020):
What do you mean with PR?
@BlackDex commented on GitHub (Sep 22, 2020):
Since we do not have a Synology to test on, we can't debug and test these changes.
Also, since almost any and all systems work this way, we do not want to break stuff.
So if someone has a fix, they can request to merge/pull that change into the master branch.
@Crow-Control commented on GitHub (Feb 18, 2021):
@newkind maybe file an issue with Synology instead?
Because they thosen to use a non-standard environment var (which is a bad idea) AND choose to use env-vars instead of docker to set permissions in the first place (also not in compliance with any decent docker standard).
It shouldn't be up to every container out there to fix the fuckups by synology imho.
@7opf commented on GitHub (Feb 19, 2021):
The issue is that the UI from Synology's Docker package doesn't support the
--userflag (in addition to some others like--cap-add). Current work around to get this project to run non-root would be to ssh into the NAS and usedocker-compose.Your compose file might look something like this
When you are ready, run compose. You'll see the container will turn up in the UI as well
Disclaimer: I haven't actually tested this yet. Will probably try this week.
Some refs
https://docs.docker.com/compose/compose-file/compose-file-v3/#domainname-hostname-ipc-mac_address-privileged-read_only-shm_size-stdin_open-tty-user-working_dir
https://github.com/dani-garcia/bitwarden_rs/wiki/Using-Docker-Compose
@7opf commented on GitHub (Feb 28, 2021):
What ended up working for me on Synology was this:
Docker didn't like re-using the pre-existing network synology sets up so you can let it create one automatically. I didn't need to configure anything special in the firewall for it to work contrary to my prev comment.
@DrDeath commented on GitHub (Apr 18, 2021):
I can confirm, this is working on a synology NAS.
Maybe this solution could be inserted into the wiki.
Edit: Already in the Wiki: https://github.com/dani-garcia/bitwarden_rs/wiki/Hardening-Guide
@waschinski commented on GitHub (Apr 29, 2021):
I am using portainer on my Synology NAS and don't see any option to set
user. So having ENV variables for UID/GID would still be helpful in my use case.@MilesTEG1 commented on GitHub (Jun 26, 2021):
I use docker on a Synology DS920+, and I use PGID and PUID.
Here an extract of my docker-compose.yml (with Portainer, or docker-compose in SSH) :