[PR #6881] [CLOSED] Add Google S2 icon cache fallback for favicon fetching #3869

New issue

Closed

opened 2026-03-03 10:38:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 10:38:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6881
Author: @Shocker
Created: 2/27/2026
Status: ❌ Closed

Base: main ← Head: google-s2-fallback

📝 Commits (1)

34536bd Add Google S2 icon cache fallback for favicon fetching

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 src/api/icons.rs (+3 -0)

📄 Description

LATER EDIT: ignore the request but see the comments below

In case the favicon download fails due to anti-bot/anti-crawler techniques (most likely HTTP code 403 or even 444) fallback to Google icon cache which is almost sure to have the favicon cached.

While it may seem a bad idea to hardcode links like this, an increasingly amount of sites started using such techniques, especially aggressive Cloudflare-protected sites, causing Vaultwarden to fail in fetching favicons

P.S.: For this pull request to work, https://github.com/dani-garcia/vaultwarden/pull/6880 also needs to be accepted/merged

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6881 **Author:** [@Shocker](https://github.com/Shocker) **Created:** 2/27/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `google-s2-fallback` --- ### 📝 Commits (1) - [`34536bd`](https://github.com/dani-garcia/vaultwarden/commit/34536bde95c9a027c57ed22447dd72f0e3272d75) Add Google S2 icon cache fallback for favicon fetching ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+3 -0) </details> ### 📄 Description **LATER EDIT: ignore the request but see the comments below** In case the favicon download fails due to anti-bot/anti-crawler techniques (most likely HTTP code 403 or even 444) fallback to Google icon cache which is almost sure to have the favicon cached. While it may seem a bad idea to hardcode links like this, an increasingly amount of sites started using such techniques, especially aggressive Cloudflare-protected sites, causing Vaultwarden to fail in fetching favicons P.S.: For this pull request to work, https://github.com/dani-garcia/vaultwarden/pull/6880 also needs to be accepted/merged --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>