[PR #6882] Implement Fallback Icon service #3868

New issue

Open

opened 2026-03-03 10:38:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 10:38:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6882
Author: @Shocker
Created: 2/27/2026
Status: 🔄 Open

Base: main ← Head: icon-service-fallback

📝 Commits (1)

7287a12 Implement Fallback Icon service

📊 Changes

2 files changed (+35 additions, -1 deletions)

View changed files

📝 src/api/icons.rs (+8 -1)
📝 src/config.rs (+27 -0)

📄 Description

Following the discussion from here https://github.com/dani-garcia/vaultwarden/pull/6881 add a separate config to allow fallback to external icon services icon URL (bitwarden, duckduckgo, google) when using the internal icon service in case all the default icon links fail to be downloaded (possibly due to anti-bot/anti-crawler techniques)

P.S.: For this pull request to work, https://github.com/dani-garcia/vaultwarden/pull/6880 MUST be accepted/merged. After that this PR will require a small code change to accomodate for those new changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6882 **Author:** [@Shocker](https://github.com/Shocker) **Created:** 2/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `icon-service-fallback` --- ### 📝 Commits (1) - [`7287a12`](https://github.com/dani-garcia/vaultwarden/commit/7287a121fbe8b02c435e6fc3190aa9069b836318) Implement Fallback Icon service ### 📊 Changes **2 files changed** (+35 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+8 -1) 📝 `src/config.rs` (+27 -0) </details> ### 📄 Description Following the discussion from here https://github.com/dani-garcia/vaultwarden/pull/6881 add a separate config to allow fallback to external icon services icon URL (bitwarden, duckduckgo, google) when using the internal icon service in case all the default icon links fail to be downloaded (possibly due to anti-bot/anti-crawler techniques) P.S.: For this pull request to work, https://github.com/dani-garcia/vaultwarden/pull/6880 MUST be accepted/merged. After that this PR will require a small code change to accomodate for those new changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>