[PR #6880] Fix favicon fetching to check all icon links instead of just the first one #3866

New issue

Open

opened 2026-03-03 10:38:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 10:38:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6880
Author: @Shocker
Created: 2/27/2026
Status: 🔄 Open

Base: main ← Head: fix-all-icons

📝 Commits (2)

b7acf97 Fix favicon fetching to check all icon links instead of just the first one
0d68502 revert max icons limit removal

📊 Changes

1 file changed (+17 additions, -3 deletions)

View changed files

📝 src/api/icons.rs (+17 -3)

📄 Description

Fix logic in download_icon(), got broken (most likely accidentally) in github.com/dani-garcia/vaultwarden@27dc67fadd (diff-c0f730ed83) which caused the downloader to stop after first error

~~Also don't limit max checked icons to 5, allow all icons in the list~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6880 **Author:** [@Shocker](https://github.com/Shocker) **Created:** 2/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-all-icons` --- ### 📝 Commits (2) - [`b7acf97`](https://github.com/dani-garcia/vaultwarden/commit/b7acf975ba5625bc4e48c4ba7358e736544aa9cd) Fix favicon fetching to check all icon links instead of just the first one - [`0d68502`](https://github.com/dani-garcia/vaultwarden/commit/0d685026eb655b2caf021298014682cc8cea7024) revert max icons limit removal ### 📊 Changes **1 file changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+17 -3) </details> ### 📄 Description Fix logic in `download_icon()`, got broken (most likely accidentally) in https://github.com/dani-garcia/vaultwarden/commit/27dc67fadd3d45b9f7d8d37407cef9453b8f5802#diff-c0f730ed83eb02623c5c9bde35b0366115b8961fb596c27f98613140cba6d2a7L714 which caused the downloader to stop after first error ~~Also don't limit max checked icons to 5, allow all icons in the list~~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>