[PR #6222] [CLOSED] Fix: SSO Numeric Normalization to recover from preventable SSO failures #3750

New issue

Closed

opened 2026-03-03 10:21:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 10:21:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6222
Author: @krparajuli
Created: 8/25/2025
Status: ❌ Closed

Base: main ← Head: sso_numeric_normalization

📝 Commits (1)

fb0a0c2 Added SSO numeric normalizations

📊 Changes

1 file changed (+93 additions, -21 deletions)

View changed files

📝 src/sso_client.rs (+93 -21)

📄 Description

In testing SSO with Microsoft Entra, the SSO fails due to Microsoft Entra supplying time valued fields particularly related to expiry of tokens consist of strings rather than integers.

This causes current SSO flow to error out.

This commit attempts recovery by trying to parse the strings value of relevant fields to integers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6222 **Author:** [@krparajuli](https://github.com/krparajuli) **Created:** 8/25/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `sso_numeric_normalization` --- ### 📝 Commits (1) - [`fb0a0c2`](https://github.com/dani-garcia/vaultwarden/commit/fb0a0c2ca7463837f2f9d5e17151dd9b9c2c799e) Added SSO numeric normalizations ### 📊 Changes **1 file changed** (+93 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/sso_client.rs` (+93 -21) </details> ### 📄 Description In testing SSO with Microsoft Entra, the SSO fails due to Microsoft Entra supplying time valued fields particularly related to expiry of tokens consist of strings rather than integers. This causes current SSO flow to error out. <img width="346" height="194" alt="Screenshot 2025-08-19 at 11 39 36" src="https://github.com/user-attachments/assets/34d50c5a-f5af-4c45-968d-a0d0c49c43bf" /> This commit attempts recovery by trying to parse the strings value of relevant fields to integers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>