starred/vaultwarden

Fork 0

mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-04-26 01:35:54 +03:00

[GH-ISSUE #570] icon not downloading over outgoing proxy #374

New issue

Closed

opened 2026-03-03 01:28:30 +03:00 by kerem · 6 comments

kerem commented

2026-03-03 01:28:30 +03:00

Owner

Originally created by @kTitan on GitHub (Aug 12, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/570

Currently It looks like that my bitwarden_rs installation is not able to fetch icons, because it runs inside a restrictive network.
Outgoing connections are not allowed, only via an normal proxy.
For that I tried to set these environment variables for the docker container:

http_proxy: 'http://proxy:8888/'
https_proxy: 'http://proxy:8888/'

But after that I still get these errors:

[2019-08-11 08:31:24][rocket::rocket][INFO] GET /icons/accounts.autodesk.com/icon.png image/png:
[2019-08-11 08:31:24][_][INFO] Matched: GET /icons/<domain>/icon.png (icon)
[2019-08-11 08:31:39][bitwarden_rs::api::icons][INFO] Download failed for https://accounts.autodesk.com/favicon.ico
[2019-08-11 08:31:39][bitwarden_rs::api::icons][ERROR] Error downloading icon: Empty response. Empty response
thread '<unnamed>' panicked at 'Error creating negative cache marker: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1051:5

I have seen that the rust lib https://github.com/seanmonstar/reqwest/releases added the support for use of system proxy in the latest release, and that you are already using it.
But I do not know how much work it would be to activate the feature inside the code.

Originally created by @kTitan on GitHub (Aug 12, 2019). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/570 Currently It looks like that my bitwarden_rs installation is not able to fetch icons, because it runs inside a restrictive network. Outgoing connections are not allowed, only via an normal proxy. For that I tried to set these environment variables for the docker container: ``` http_proxy: 'http://proxy:8888/' https_proxy: 'http://proxy:8888/' ``` But after that I still get these errors: ``` [2019-08-11 08:31:24][rocket::rocket][INFO] GET /icons/accounts.autodesk.com/icon.png image/png: [2019-08-11 08:31:24][_][INFO] Matched: GET /icons/<domain>/icon.png (icon) [2019-08-11 08:31:39][bitwarden_rs::api::icons][INFO] Download failed for https://accounts.autodesk.com/favicon.ico [2019-08-11 08:31:39][bitwarden_rs::api::icons][ERROR] Error downloading icon: Empty response. Empty response thread '<unnamed>' panicked at 'Error creating negative cache marker: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:1051:5 ``` I have seen that the rust lib https://github.com/seanmonstar/reqwest/releases added the support for use of system proxy in the latest release, and that you are already using it. But I do not know how much work it would be to activate the feature inside the code.

kerem closed this issue

2026-03-03 01:28:30 +03:00

kerem commented

2026-03-03 01:28:31 +03:00

Author

Owner

@BlackDex commented on GitHub (Aug 12, 2019):

@kTitan I have created a pull-request for this feature. It was a small update.
I tested it and works as it should.

@BlackDex commented on GitHub (Aug 12, 2019): @kTitan I have created a pull-request for this feature. It was a small update. I tested it and works as it should.

kerem commented

2026-03-03 01:28:31 +03:00

Author

Owner

@kTitan commented on GitHub (Aug 12, 2019):

@BlackDex thanks for this quick pull request.
I just have seen that the hibp_breach function is also not working, because it also needs the proxy.
Could you add it there also? If you want I can also open an new issue for that.

@kTitan commented on GitHub (Aug 12, 2019): @BlackDex thanks for this quick pull request. I just have seen that the `hibp_breach` function is also not working, because it also needs the proxy. Could you add it there also? If you want I can also open an new issue for that.

kerem commented

2026-03-03 01:28:31 +03:00

Author

Owner

@BlackDex commented on GitHub (Aug 13, 2019):

@kTitan There are some more locations where this could be needed.
the DUO auth is something i can see quicly.

@BlackDex commented on GitHub (Aug 13, 2019): @kTitan There are some more locations where this could be needed. the DUO auth is something i can see quicly.

kerem commented

2026-03-03 01:28:31 +03:00

Author

Owner

@BlackDex commented on GitHub (Aug 13, 2019):

Maybe it is better for this to wait for the updated reqwest module, since that will enable the use_sys_proxy by default. But that will only be by default in the 0.10 version and currently it is at 0.9

@BlackDex commented on GitHub (Aug 13, 2019): Maybe it is better for this to wait for the updated reqwest module, since that will enable the use_sys_proxy by default. But that will only be by default in the 0.10 version and currently it is at 0.9

kerem commented

2026-03-03 01:28:31 +03:00

Author

Owner

@kTitan commented on GitHub (Aug 13, 2019):

But there is no release date scheduled for the 0.10 version if it, as far as I can see. So it will perhaps takes months/years :/

@kTitan commented on GitHub (Aug 13, 2019): But there is no release date scheduled for the 0.10 version if it, as far as I can see. So it will perhaps takes months/years :/

kerem commented

2026-03-03 01:28:31 +03:00

Author

Owner

@mprasil commented on GitHub (Aug 20, 2019):

#571 was now merged, so this should be resolved.

@mprasil commented on GitHub (Aug 20, 2019): #571 was now merged, so this should be resolved.