[PR #6151] [MERGED] Fix several more multi select push issues #3727

New issue

Closed

opened 2026-03-03 10:21:15 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 10:21:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6151
Author: @BlackDex
Created: 8/8/2025
Status: ✅ Merged
Merged: 8/9/2025
Merged by: @dani-garcia

Base: main ← Head: more-multi-push-fixes

📝 Commits (2)

5c103ff Fix several more multi select push issues
f8bbe3d Update src/api/core/ciphers.rs

📊 Changes

3 files changed (+112 additions, -39 deletions)

View changed files

📝 src/api/core/ciphers.rs (+68 -30)
📝 src/db/models/auth_request.rs (+1 -1)
📝 src/db/models/cipher.rs (+43 -8)

📄 Description

There were some more items which would still overload the push endpoint. This PR fixes the remaining items (I hope).

I also encountered a missing endpoint for restoring multiple ciphers from the trash via the admin console.

Overall, we could improve a lot of these items in a different way. Like bundle all SQL Queries etc... But that takes more time, and this fixes overloading the Bitwarden push servers, and speeds up these specific actions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6151 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 8/8/2025 **Status:** ✅ Merged **Merged:** 8/9/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `more-multi-push-fixes` --- ### 📝 Commits (2) - [`5c103ff`](https://github.com/dani-garcia/vaultwarden/commit/5c103ff55c211bfa5bbd4928a93645e44dd9dc4f) Fix several more multi select push issues - [`f8bbe3d`](https://github.com/dani-garcia/vaultwarden/commit/f8bbe3d2371292fdc9912a86b44ae1afe8c07dc8) Update src/api/core/ciphers.rs ### 📊 Changes **3 files changed** (+112 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+68 -30) 📝 `src/db/models/auth_request.rs` (+1 -1) 📝 `src/db/models/cipher.rs` (+43 -8) </details> ### 📄 Description There were some more items which would still overload the push endpoint. This PR fixes the remaining items (I hope). I also encountered a missing endpoint for restoring multiple ciphers from the trash via the admin console. Overall, we could improve a lot of these items in a different way. Like bundle all SQL Queries etc... But that takes more time, and this fixes overloading the Bitwarden push servers, and speeds up these specific actions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>