[GH-ISSUE #565] Icon extraction fails #367

Closed
opened 2026-03-03 01:28:27 +03:00 by kerem · 5 comments
Owner

Originally created by @quthla on GitHub (Aug 10, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/565

For saturn.de and bwin.com it will just create the miss file

Originally created by @quthla on GitHub (Aug 10, 2019). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/565 For saturn.de and bwin.com it will just create the miss file
kerem 2026-03-03 01:28:27 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@mprasil commented on GitHub (Aug 10, 2019):

What version are you using?

<!-- gh-comment-id:520178638 --> @mprasil commented on GitHub (Aug 10, 2019): What version are you using?
Author
Owner

@quthla commented on GitHub (Aug 10, 2019):

Latest docker image. Were you unable to reproduce the issue?

<!-- gh-comment-id:520180536 --> @quthla commented on GitHub (Aug 10, 2019): Latest docker image. Were you unable to reproduce the issue?
Author
Owner

@mprasil commented on GitHub (Aug 11, 2019):

I think I was able to reproduce that with saturn.de, but bwin.com works fine for me. I'm not sure why saturn.de fails though, I can see this in logs:

Download failed for https://www.saturn.de/favicon.ico

But when I try to poke the same URL with curl, it works fine.

<!-- gh-comment-id:520213529 --> @mprasil commented on GitHub (Aug 11, 2019): I think I was able to reproduce that with saturn.de, but bwin.com works fine for me. I'm not sure why saturn.de fails though, I can see this in logs: ``` Download failed for https://www.saturn.de/favicon.ico ``` But when I try to poke the same URL with curl, it works fine.
Author
Owner

@BlackDex commented on GitHub (Aug 13, 2019):

I have identified the bug this afternoon. It has to do with cookies, and rather the lack off but still sending the header. This breaks the saturn.de website. Trying to think of a good way to fix this.

<!-- gh-comment-id:520820249 --> @BlackDex commented on GitHub (Aug 13, 2019): I have identified the bug this afternoon. It has to do with cookies, and rather the lack off but still sending the header. This breaks the saturn.de website. Trying to think of a good way to fix this.
Author
Owner

@mprasil commented on GitHub (Oct 11, 2019):

This was fixed in PR #644

<!-- gh-comment-id:541002939 --> @mprasil commented on GitHub (Oct 11, 2019): This was fixed in PR #644
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#367
No description provided.