[PR #5490] [CLOSED] Add passkey support to Vaultwarden #3630

Closed
opened 2026-03-03 10:05:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5490
Author: @p4rzl
Created: 1/28/2025
Status: Closed

Base: mainHead: add-passkey-support


📝 Commits (2)

  • 2bec0ff Add passkey support to Vaultwarden
  • c1cc952 Add support for passkeys in admin and user interfaces

📊 Changes

10 files changed (+178 additions, -4 deletions)

View changed files

migrations/mysql/2025-01-09-172300_add_passkey_support/up.sql (+3 -0)
migrations/postgresql/2025-01-09-172300_add_passkey_support/up.sql (+3 -0)
migrations/sqlite/2025-01-09-172300_add_passkey_support/up.sql (+3 -0)
📝 src/api/admin.rs (+63 -0)
📝 src/api/core/ciphers.rs (+4 -1)
📝 src/api/core/public.rs (+33 -1)
📝 src/db/models/cipher.rs (+17 -2)
📝 src/static/templates/admin/settings.hbs (+14 -0)
📝 src/static/templates/admin/users.hbs (+4 -0)
src/static/templates/user/login.hbs (+34 -0)

📄 Description

Add support for saving and using passkeys, and importing them via .json.

  • src/api/core/ciphers.rs

    • Add Passkey type to CipherData struct.
    • Update update_cipher_from_data function to handle passkeys.
    • Modify post_ciphers_import function to import passkeys.
  • src/db/models/cipher.rs

    • Add Passkey type to Cipher struct.
    • Update type_data_json handling to include passkeys.
    • Add validation for passkey entries.
  • Database Migrations

    • Add SQL statements to add passkey fields to MySQL, PostgreSQL, and SQLite schemas.
  • src/api/admin.rs

    • Add endpoints for managing passkeys: get_passkeys, get_passkey, create_passkey, update_passkey, delete_passkey.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5490 **Author:** [@p4rzl](https://github.com/p4rzl) **Created:** 1/28/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-passkey-support` --- ### 📝 Commits (2) - [`2bec0ff`](https://github.com/dani-garcia/vaultwarden/commit/2bec0ff2fd745c291ccd47a31e3510a6125af3b1) Add passkey support to Vaultwarden - [`c1cc952`](https://github.com/dani-garcia/vaultwarden/commit/c1cc9527ddae332261a774b415170a5420376f0d) Add support for passkeys in admin and user interfaces ### 📊 Changes **10 files changed** (+178 additions, -4 deletions) <details> <summary>View changed files</summary> ➕ `migrations/mysql/2025-01-09-172300_add_passkey_support/up.sql` (+3 -0) ➕ `migrations/postgresql/2025-01-09-172300_add_passkey_support/up.sql` (+3 -0) ➕ `migrations/sqlite/2025-01-09-172300_add_passkey_support/up.sql` (+3 -0) 📝 `src/api/admin.rs` (+63 -0) 📝 `src/api/core/ciphers.rs` (+4 -1) 📝 `src/api/core/public.rs` (+33 -1) 📝 `src/db/models/cipher.rs` (+17 -2) 📝 `src/static/templates/admin/settings.hbs` (+14 -0) 📝 `src/static/templates/admin/users.hbs` (+4 -0) ➕ `src/static/templates/user/login.hbs` (+34 -0) </details> ### 📄 Description Add support for saving and using passkeys, and importing them via .json. * **src/api/core/ciphers.rs** - Add `Passkey` type to `CipherData` struct. - Update `update_cipher_from_data` function to handle passkeys. - Modify `post_ciphers_import` function to import passkeys. * **src/db/models/cipher.rs** - Add `Passkey` type to `Cipher` struct. - Update `type_data_json` handling to include passkeys. - Add validation for passkey entries. * **Database Migrations** - Add SQL statements to add passkey fields to MySQL, PostgreSQL, and SQLite schemas. * **src/api/admin.rs** - Add endpoints for managing passkeys: `get_passkeys`, `get_passkey`, `create_passkey`, `update_passkey`, `delete_passkey`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 10:05:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3630
No description provided.