[PR #5379] [MERGED] Fix an issue with login with device #3613

Closed
opened 2026-03-03 10:04:58 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5379
Author: @BlackDex
Created: 1/10/2025
Status: Merged
Merged: 1/10/2025
Merged by: @dani-garcia

Base: mainHead: fix-login-with-device


📝 Commits (1)

  • b579286 Fix an issue with login with device

📊 Changes

3 files changed (+15 additions, -15 deletions)

View changed files

📝 src/api/core/accounts.rs (+1 -1)
📝 src/api/notifications.rs (+9 -9)
📝 src/api/push.rs (+5 -5)

📄 Description

During the refactoring done in #5320 there has a buggy slipped through which changed a uuid. This commit fixes this, and also made some vars pass by reference.

Fixes #5377


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5379 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-login-with-device` --- ### 📝 Commits (1) - [`b579286`](https://github.com/dani-garcia/vaultwarden/commit/b57928646e5955b1bb1a9a40bcd5bd416dc615e0) Fix an issue with login with device ### 📊 Changes **3 files changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+1 -1) 📝 `src/api/notifications.rs` (+9 -9) 📝 `src/api/push.rs` (+5 -5) </details> ### 📄 Description During the refactoring done in #5320 there has a buggy slipped through which changed a uuid. This commit fixes this, and also made some vars pass by reference. Fixes #5377 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 10:04:58 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3613
No description provided.