[PR #5184] [MERGED] Remove auth-request deletion #3574

New issue

Closed

opened 2026-03-03 10:04:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 10:04:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5184
Author: @BlackDex
Created: 11/12/2024
Status: ✅ Merged
Merged: 11/12/2024
Merged by: @dani-garcia

Base: main ← Head: fix-auth-request-with-2fa

📝 Commits (1)

8672a97 Remove auth-request deletion

📊 Changes

1 file changed (+0 additions, -3 deletions)

View changed files

📝 src/api/identity.rs (+0 -3)

📄 Description

2FA is needed to login even when using login-with-device. If the user didn't saved the 2FA token they still need to provide this. We deleted the auth-request after validation the request, but before 2FA was triggered.

Removing the deletion of this record from that point as it will get cleaned-up automatically anyways.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5184 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 11/12/2024 **Status:** ✅ Merged **Merged:** 11/12/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-auth-request-with-2fa` --- ### 📝 Commits (1) - [`8672a97`](https://github.com/dani-garcia/vaultwarden/commit/8672a979a5048fe72fbef3e52cac5c6ea0e3ae4d) Remove auth-request deletion ### 📊 Changes **1 file changed** (+0 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/api/identity.rs` (+0 -3) </details> ### 📄 Description 2FA is needed to login even when using login-with-device. If the user didn't saved the 2FA token they still need to provide this. We deleted the auth-request after validation the request, but before 2FA was triggered. Removing the deletion of this record from that point as it will get cleaned-up automatically anyways. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>