[PR #4966] [MERGED] Fix Pw History null dates #3546

New issue

Closed

opened 2026-03-03 10:04:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 10:04:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4966
Author: @BlackDex
Created: 9/18/2024
Status: ✅ Merged
Merged: 9/18/2024
Merged by: @dani-garcia

Base: main ← Head: fix-pw-history-null-date

📝 Commits (1)

bec98a7 Fix Pw History null dates

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 src/db/models/cipher.rs (+9 -0)

📄 Description

It seemed to have been possible to have null date values. This PR fixes this by setting the epoch start date if either the date does not exists or is not a string.

This should solve sync issues with the new native mobile clients.

Fixes https://github.com/dani-garcia/vaultwarden/pull/4932#issuecomment-2357581292

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4966 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/18/2024 **Status:** ✅ Merged **Merged:** 9/18/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-pw-history-null-date` --- ### 📝 Commits (1) - [`bec98a7`](https://github.com/dani-garcia/vaultwarden/commit/bec98a71f6ae2768d7a41652e1cf57bd9ea54c50) Fix Pw History null dates ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/db/models/cipher.rs` (+9 -0) </details> ### 📄 Description It seemed to have been possible to have `null` date values. This PR fixes this by setting the epoch start date if either the date does not exists or is not a string. This should solve sync issues with the new native mobile clients. Fixes https://github.com/dani-garcia/vaultwarden/pull/4932#issuecomment-2357581292 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>