[PR #4168] [MERGED] Allow customizing the featureStates #3388

Closed
opened 2026-03-03 09:58:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4168
Author: @PKizzle
Created: 12/14/2023
Status: Merged
Merged: 1/1/2024
Merged by: @dani-garcia

Base: mainHead: feature/customize-feature-flags


📝 Commits (10+)

📊 Changes

4 files changed (+36 additions, -11 deletions)

View changed files

📝 .env.template (+11 -0)
📝 src/api/core/mod.rs (+4 -10)
📝 src/config.rs (+12 -1)
📝 src/util.rs (+9 -0)

📄 Description

Instead of statically disabling autofill-v2 and enabling fido2-vault-credentials let the user decide which features to en-/disable.

By default the above mentioned standard values are used but can be changed by specifying a comma separated list of any of the currently available in the bitwarden clients: github.com/bitwarden/clients@00fd45a678/libs/common/src/enums/feature-flag.enum.ts

To disable a feature just prepend an exclamation mark (!). The default value is: !autofill-v2,fido2-vault-credentials


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4168 **Author:** [@PKizzle](https://github.com/PKizzle) **Created:** 12/14/2023 **Status:** ✅ Merged **Merged:** 1/1/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `feature/customize-feature-flags` --- ### 📝 Commits (10+) - [`e62de29`](https://github.com/dani-garcia/vaultwarden/commit/e62de29ebfdb428e42d2a61fedde573a0b7a49f2) Allow customizing the featureStates - [`2072d6e`](https://github.com/dani-garcia/vaultwarden/commit/2072d6ec6097c27ea402c24827f8b05e7c3633ba) Merge branch 'main' of https://github.com/dani-garcia/vaultwarden - [`646cede`](https://github.com/dani-garcia/vaultwarden/commit/646cedeea63b3722d6490c4612e9af663155126f) Move feature flag parsing to util - [`f12e288`](https://github.com/dani-garcia/vaultwarden/commit/f12e288dceb883f3130444cd2779ee58c3406ddf) Merge branch 'main' of https://github.com/dani-garcia/vaultwarden - [`9dea157`](https://github.com/dani-garcia/vaultwarden/commit/9dea15702ed2769c9ca39942dabbeaf02337d358) Fix formatting - [`9424629`](https://github.com/dani-garcia/vaultwarden/commit/942462983d9b2344f98f115b76db386cf5598eff) Update supported feature flags - [`2d45af2`](https://github.com/dani-garcia/vaultwarden/commit/2d45af26b68fa4954b1e14bbd94f97669d7cabae) Rename feature_flags to experimental_client_feature_flags - [`4bdfa7b`](https://github.com/dani-garcia/vaultwarden/commit/4bdfa7bc1d414a42e286b5107b0d0b4c6cb4aa49) Fix formatting issue. - [`c52ffc7`](https://github.com/dani-garcia/vaultwarden/commit/c52ffc70ea0fdb38374ef84fe752bdcc2aeacab2) Add documentation to env template - [`4507c11`](https://github.com/dani-garcia/vaultwarden/commit/4507c118e74ecd77faab2161b0095c30c4b9aa18) Remove functionality to disable feature flags ### 📊 Changes **4 files changed** (+36 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+11 -0) 📝 `src/api/core/mod.rs` (+4 -10) 📝 `src/config.rs` (+12 -1) 📝 `src/util.rs` (+9 -0) </details> ### 📄 Description Instead of statically disabling autofill-v2 and enabling fido2-vault-credentials let the user decide which features to en-/disable. By default the above mentioned standard values are used but can be changed by specifying a comma separated list of any of the currently available in the bitwarden clients: https://github.com/bitwarden/clients/blob/00fd45a678956c76dde6caa76e8ba266c204471c/libs/common/src/enums/feature-flag.enum.ts ~To disable a feature just prepend an exclamation mark (!). The default value is: `!autofill-v2,fido2-vault-credentials`~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:58:41 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3388
No description provided.