[PR #3639] [CLOSED] release optimization #3322

Closed
opened 2026-03-03 09:58:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3639
Author: @tessus
Created: 7/3/2023
Status: Closed

Base: mainHead: build/release-optimization


📝 Commits (1)

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 Cargo.toml (+7 -3)

📄 Description

This optimization is not only for size but also runtime. Who doesn't want to use less CPU cycles? ;-)

Since releases are not done that often and usually via build machines and pipelines, I don't see it as an issue that the build time doubled.

That being said, if this is too extreme for a default release, I can also add another profile (e.g. called production or something similar).

Description Change Before After
Build time +110% 5min 31s 11min 34s
Binary size (bytes) -42% 49466432 28576480

Build command: cargo build --features sqlite,mysql,postgresql --release


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3639 **Author:** [@tessus](https://github.com/tessus) **Created:** 7/3/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `build/release-optimization` --- ### 📝 Commits (1) - [`4fa4600`](https://github.com/dani-garcia/vaultwarden/commit/4fa4600e1128be35d6139332bcebf5302eea8316) release optimization ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+7 -3) </details> ### 📄 Description This optimization is not only for size but also runtime. Who doesn't want to use less CPU cycles? ;-) Since releases are not done that often and usually via build machines and pipelines, I don't see it as an issue that the build time doubled. That being said, if this is too extreme for a default release, I can also add another profile (e.g. called `production` or something similar). | Description | Change | Before | After | |---------------------|--------|----------|-----------| | Build time | +110% | 5min 31s | 11min 34s | | Binary size (bytes) | -42% | 49466432 | 28576480 | Build command: `cargo build --features sqlite,mysql,postgresql --release` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:58:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3322
No description provided.