[GH-ISSUE #522] Interested in a linting task for the various Dockerfiles in this repo? #330

New issue

Closed

opened 2026-03-03 01:28:02 +03:00 by kerem · 3 comments

kerem commented 2026-03-03 01:28:02 +03:00

Owner

Copy link

Originally created by @fbartels on GitHub (Jul 3, 2019).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/522

Hi,

I have just run hadolint ontop of the latest pr for updating the Dockerfiles and it prints out the following:

 $  git ls-files --exclude='Dockerfile*' --ignored | xargs --max-lines=1 hadolint
Dockerfile:5 DL3006 Always tag the version of an image explicitly
Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
Dockerfile:24 DL3006 Always tag the version of an image explicitly
Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
Dockerfile:96 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/aarch64/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/aarch64/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/aarch64/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/aarch64/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/aarch64/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/aarch64/mysql/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/aarch64/mysql/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/aarch64/mysql/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/aarch64/mysql/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/aarch64/mysql/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/aarch64/mysql/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/aarch64/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/aarch64/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/aarch64/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/aarch64/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/aarch64/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/aarch64/sqlite/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/aarch64/sqlite/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/aarch64/sqlite/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/aarch64/sqlite/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/aarch64/sqlite/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/aarch64/sqlite/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/amd64/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/amd64/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/amd64/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/amd64/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/amd64/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/amd64/mysql/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/amd64/mysql/Dockerfile:96 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/amd64/mysql/Dockerfile.alpine:5 DL3006 Always tag the version of an image explicitly
docker/amd64/mysql/Dockerfile.alpine:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/amd64/mysql/Dockerfile.alpine:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/amd64/mysql/Dockerfile.alpine:31 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/amd64/mysql/Dockerfile.alpine:60 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/amd64/mysql/Dockerfile.alpine:76 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/amd64/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/amd64/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/amd64/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/amd64/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/amd64/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/amd64/sqlite/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/amd64/sqlite/Dockerfile:96 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/amd64/sqlite/Dockerfile.alpine:5 DL3006 Always tag the version of an image explicitly
docker/amd64/sqlite/Dockerfile.alpine:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/amd64/sqlite/Dockerfile.alpine:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/amd64/sqlite/Dockerfile.alpine:31 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/amd64/sqlite/Dockerfile.alpine:60 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/amd64/sqlite/Dockerfile.alpine:76 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/armv6/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/armv6/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/armv6/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/armv6/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/armv6/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/armv6/mysql/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv6/mysql/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv6/mysql/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv6/mysql/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv6/mysql/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv6/mysql/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/armv6/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/armv6/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/armv6/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/armv6/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/armv6/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/armv6/sqlite/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv6/sqlite/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv6/sqlite/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv6/sqlite/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv6/sqlite/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv6/sqlite/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/armv7/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/armv7/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/armv7/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/armv7/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/armv7/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/armv7/mysql/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv7/mysql/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv7/mysql/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv7/mysql/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv7/mysql/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv7/mysql/Dockerfile:98 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments
docker/armv7/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly
docker/armv7/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`
docker/armv7/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages
docker/armv7/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it
docker/armv7/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly
docker/armv7/sqlite/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv7/sqlite/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv7/sqlite/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv7/sqlite/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends`
docker/armv7/sqlite/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
docker/armv7/sqlite/Dockerfile:98 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments

Quite a lot of this is duplicate and not all recommendations really need to be followed (pinning exact package version imho just makes sense if you want to spent resources on constantly updating your dockerfiles).

If you like I could add hadolint as a step to the travis.yml and also work a bit on resolving these warnings.

Originally created by @fbartels on GitHub (Jul 3, 2019). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/522 Hi, I have just run hadolint ontop of the [latest pr for updating the Dockerfiles](https://github.com/dani-garcia/bitwarden_rs/pull/521) and it prints out the following: ``` $ git ls-files --exclude='Dockerfile*' --ignored | xargs --max-lines=1 hadolint Dockerfile:5 DL3006 Always tag the version of an image explicitly Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it Dockerfile:24 DL3006 Always tag the version of an image explicitly Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` Dockerfile:96 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/aarch64/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/aarch64/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/aarch64/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/aarch64/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/aarch64/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/aarch64/mysql/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/aarch64/mysql/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/aarch64/mysql/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/aarch64/mysql/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/aarch64/mysql/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/aarch64/mysql/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/aarch64/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/aarch64/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/aarch64/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/aarch64/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/aarch64/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/aarch64/sqlite/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/aarch64/sqlite/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/aarch64/sqlite/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/aarch64/sqlite/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/aarch64/sqlite/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/aarch64/sqlite/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/amd64/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/amd64/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/amd64/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/amd64/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/amd64/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/amd64/mysql/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/amd64/mysql/Dockerfile:96 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/amd64/mysql/Dockerfile.alpine:5 DL3006 Always tag the version of an image explicitly docker/amd64/mysql/Dockerfile.alpine:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/amd64/mysql/Dockerfile.alpine:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/amd64/mysql/Dockerfile.alpine:31 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/amd64/mysql/Dockerfile.alpine:60 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/amd64/mysql/Dockerfile.alpine:76 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/amd64/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/amd64/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/amd64/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/amd64/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/amd64/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/amd64/sqlite/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/amd64/sqlite/Dockerfile:96 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/amd64/sqlite/Dockerfile.alpine:5 DL3006 Always tag the version of an image explicitly docker/amd64/sqlite/Dockerfile.alpine:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/amd64/sqlite/Dockerfile.alpine:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/amd64/sqlite/Dockerfile.alpine:31 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/amd64/sqlite/Dockerfile.alpine:60 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/amd64/sqlite/Dockerfile.alpine:76 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/armv6/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/armv6/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/armv6/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/armv6/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/armv6/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/armv6/mysql/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv6/mysql/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv6/mysql/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv6/mysql/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv6/mysql/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv6/mysql/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/armv6/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/armv6/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/armv6/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/armv6/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/armv6/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/armv6/sqlite/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv6/sqlite/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv6/sqlite/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv6/sqlite/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv6/sqlite/Dockerfile:76 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv6/sqlite/Dockerfile:97 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/armv7/mysql/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/armv7/mysql/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/armv7/mysql/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/armv7/mysql/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/armv7/mysql/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/armv7/mysql/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv7/mysql/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv7/mysql/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv7/mysql/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv7/mysql/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv7/mysql/Dockerfile:98 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments docker/armv7/sqlite/Dockerfile:5 DL3006 Always tag the version of an image explicitly docker/armv7/sqlite/Dockerfile:11 DL3018 Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` docker/armv7/sqlite/Dockerfile:11 DL3019 Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages docker/armv7/sqlite/Dockerfile:18 DL4006 Set the SHELL option -o pipefail before RUN with a pipe in it docker/armv7/sqlite/Dockerfile:24 DL3006 Always tag the version of an image explicitly docker/armv7/sqlite/Dockerfile:29 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv7/sqlite/Dockerfile:29 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv7/sqlite/Dockerfile:42 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv7/sqlite/Dockerfile:42 DL3015 Avoid additional packages by specifying `--no-install-recommends` docker/armv7/sqlite/Dockerfile:77 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>` docker/armv7/sqlite/Dockerfile:98 DL3025 Use arguments JSON notation for CMD and ENTRYPOINT arguments ``` Quite a lot of this is duplicate and not all recommendations really need to be followed (pinning exact package version imho just makes sense if you want to spent resources on constantly updating your dockerfiles). If you like I could add hadolint as a step to the travis.yml and also work a bit on resolving these warnings.

kerem closed this issue 2026-03-03 01:28:03 +03:00

kerem commented 2026-03-03 01:28:03 +03:00

Author

Owner

Copy link

@dani-garcia commented on GitHub (Jul 3, 2019):

Well my knowledge of docker is quite simple so I'm going to assume whoever made that tool knows more than me lol. So yeah, feel free to modify the dockerfiles to reduce the warnings!

I won't mind having this step integrated in CI, but it's not like these files get modified often at all, so maybe it's not worth the effort.

<!-- gh-comment-id:508247817 --> @dani-garcia commented on GitHub (Jul 3, 2019): Well my knowledge of docker is quite simple so I'm going to assume whoever made that tool knows more than me lol. So yeah, feel free to modify the dockerfiles to reduce the warnings! I won't mind having this step integrated in CI, but it's not like these files get modified often at all, so maybe it's not worth the effort.

kerem commented 2026-03-03 01:28:03 +03:00

Author

Owner

Copy link

@fbartels commented on GitHub (Jul 4, 2019):

OK, will likely look into this over the weekend.

<!-- gh-comment-id:508359388 --> @fbartels commented on GitHub (Jul 4, 2019): OK, will likely look into this over the weekend.

kerem commented 2026-03-03 01:28:04 +03:00

Author

Owner

Copy link

@mprasil commented on GitHub (Jul 7, 2019):

I think we can close this and continue discussion in #525

<!-- gh-comment-id:509007917 --> @mprasil commented on GitHub (Jul 7, 2019): I think we can close this and continue discussion in #525

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels   

SSO

  

Third party

  

better for forum

  

bug

  

bug

  

documentation

  

duplicate

  

enhancement

  

future Vault

  

future Vault

  

future Vault

  

good first issue

  

help wanted

  

low priority

  

notes

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

troubleshooting

  

wontfix

No labels

SSO

Third party

better for forum

bug

bug

documentation

duplicate

enhancement

future Vault

future Vault

future Vault

good first issue

help wanted

low priority

notes

pull-request

question

troubleshooting

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/vaultwarden#330

No description provided.