[PR #3403] [MERGED] Revert setcap, update rust and crates #3283

New issue

Closed

opened 2026-03-03 09:58:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:58:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3403
Author: @BlackDex
Created: 3/31/2023
Status: ✅ Merged
Merged: 4/2/2023
Merged by: @dani-garcia

Base: main ← Head: update-dockerfile-and-rust

📝 Commits (1)

fc43608 Revert setcap, update rust and crates

📊 Changes

21 files changed (+149 additions, -261 deletions)

View changed files

📝 .hadolint.yaml (+2 -0)
📝 Cargo.lock (+107 -130)
📝 Cargo.toml (+7 -6)
📝 docker/Dockerfile.j2 (+16 -28)
📝 docker/amd64/Dockerfile (+1 -4)
📝 docker/amd64/Dockerfile.alpine (+1 -3)
📝 docker/amd64/Dockerfile.buildkit (+1 -9)
📝 docker/amd64/Dockerfile.buildkit.alpine (+1 -8)
📝 docker/arm64/Dockerfile (+1 -4)
📝 docker/arm64/Dockerfile.alpine (+1 -3)
📝 docker/arm64/Dockerfile.buildkit (+1 -9)
📝 docker/arm64/Dockerfile.buildkit.alpine (+1 -8)
📝 docker/armv6/Dockerfile (+1 -4)
📝 docker/armv6/Dockerfile.alpine (+1 -3)
📝 docker/armv6/Dockerfile.buildkit (+1 -9)
📝 docker/armv6/Dockerfile.buildkit.alpine (+1 -8)
📝 docker/armv7/Dockerfile (+1 -4)
📝 docker/armv7/Dockerfile.alpine (+1 -3)
📝 docker/armv7/Dockerfile.buildkit (+1 -9)
📝 docker/armv7/Dockerfile.buildkit.alpine (+1 -8)

...and 1 more files

📄 Description

Revert #3170 as discussed in #3387
This appears to be a breaking change on some platforms.
And in hindsight it's better to not have this feature as there might be (hypothetical) security issues with this.
Update Dockerfile.j2 for easy version changes.
Just change it in one place instead of multiple
Updated to Rust to latest patched version
Updated crates to latest available
Pinned mimalloc to an older version, as it breaks on musl builds

Resolves #3387

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3403 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 3/31/2023 **Status:** ✅ Merged **Merged:** 4/2/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `update-dockerfile-and-rust` --- ### 📝 Commits (1) - [`fc43608`](https://github.com/dani-garcia/vaultwarden/commit/fc43608eecc6287a1966d2e551ac6d81d71dae45) Revert setcap, update rust and crates ### 📊 Changes **21 files changed** (+149 additions, -261 deletions) <details> <summary>View changed files</summary> 📝 `.hadolint.yaml` (+2 -0) 📝 `Cargo.lock` (+107 -130) 📝 `Cargo.toml` (+7 -6) 📝 `docker/Dockerfile.j2` (+16 -28) 📝 `docker/amd64/Dockerfile` (+1 -4) 📝 `docker/amd64/Dockerfile.alpine` (+1 -3) 📝 `docker/amd64/Dockerfile.buildkit` (+1 -9) 📝 `docker/amd64/Dockerfile.buildkit.alpine` (+1 -8) 📝 `docker/arm64/Dockerfile` (+1 -4) 📝 `docker/arm64/Dockerfile.alpine` (+1 -3) 📝 `docker/arm64/Dockerfile.buildkit` (+1 -9) 📝 `docker/arm64/Dockerfile.buildkit.alpine` (+1 -8) 📝 `docker/armv6/Dockerfile` (+1 -4) 📝 `docker/armv6/Dockerfile.alpine` (+1 -3) 📝 `docker/armv6/Dockerfile.buildkit` (+1 -9) 📝 `docker/armv6/Dockerfile.buildkit.alpine` (+1 -8) 📝 `docker/armv7/Dockerfile` (+1 -4) 📝 `docker/armv7/Dockerfile.alpine` (+1 -3) 📝 `docker/armv7/Dockerfile.buildkit` (+1 -9) 📝 `docker/armv7/Dockerfile.buildkit.alpine` (+1 -8) _...and 1 more files_ </details> ### 📄 Description - Revert #3170 as discussed in #3387 This appears to be a breaking change on some platforms. And in hindsight it's better to not have this feature as there might be (hypothetical) security issues with this. - Update Dockerfile.j2 for easy version changes. Just change it in one place instead of multiple - Updated to Rust to latest patched version - Updated crates to latest available - Pinned mimalloc to an older version, as it breaks on musl builds Resolves #3387 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>