mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[PR #3307] [MERGED] Add HEAD routes to avoid spurious error messages #3264
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#3264
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3307
Author: @jjlin
Created: 3/5/2023
Status: ✅ Merged
Merged: 3/6/2023
Merged by: @dani-garcia
Base:
main← Head:head-routes📝 Commits (1)
d3626ebAdd HEAD routes to avoid spurious error messages📊 Changes
1 file changed (+21 additions, -3 deletions)
View changed files
📝
src/api/web.rs(+21 -3)📄 Description
Rocket automatically implements a HEAD route when there's a matching GET route, but relying on this behavior also means a spurious error gets logged due to https://github.com/SergioBenitez/Rocket/issues/1098.
Add explicit HEAD routes for
/and/aliveto prevent uptime monitoring services from generating error messages likeNo matching routes for HEAD /. With these new routes,HEAD /only checks that the server can respond over the network, whileHEAD /alivealso checks that the database connection is alive, similar toGET /alive.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.