[PR #3231] [MERGED] Generate distinct log messages for regex vs. IP blacklisting. #3245

New issue

Closed

opened 2026-03-03 09:42:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:42:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3231
Author: @kpfleming
Created: 2/7/2023
Status: ✅ Merged
Merged: 2/12/2023
Merged by: @dani-garcia

Base: main ← Head: icon-blacklist-improvements

📝 Commits (3)

24b5784 Generate distinct log messages for regex vs. IP blacklisting.
6741b25 Ensure that all results from check_domain_blacklist_reason are cached.
6e2c3fc Merge branch 'main' into icon-blacklist-improvements

📊 Changes

1 file changed (+19 additions, -9 deletions)

View changed files

📝 src/api/icons.rs (+19 -9)

📄 Description

When an icon will not be downloaded due to matching a configured blacklist, ensure that the log message indicates the type of blacklist that was matched.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3231 **Author:** [@kpfleming](https://github.com/kpfleming) **Created:** 2/7/2023 **Status:** ✅ Merged **Merged:** 2/12/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `icon-blacklist-improvements` --- ### 📝 Commits (3) - [`24b5784`](https://github.com/dani-garcia/vaultwarden/commit/24b5784f027b04ccdb7d34b89a87e204b97bc22b) Generate distinct log messages for regex vs. IP blacklisting. - [`6741b25`](https://github.com/dani-garcia/vaultwarden/commit/6741b2590709957dffcd16d7a04b4ebdbaa92c1d) Ensure that all results from check_domain_blacklist_reason are cached. - [`6e2c3fc`](https://github.com/dani-garcia/vaultwarden/commit/6e2c3fc1cce721f459f07071b6f14120b0e31e73) Merge branch 'main' into icon-blacklist-improvements ### 📊 Changes **1 file changed** (+19 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+19 -9) </details> ### 📄 Description When an icon will not be downloaded due to matching a configured blacklist, ensure that the log message indicates the type of blacklist that was matched. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>