[PR #3228] [MERGED] Fix trailing slash not getting removed from domain #3244

New issue

Closed

opened 2026-03-03 09:42:04 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:42:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3228
Author: @BlockListed
Created: 2/6/2023
Status: ✅ Merged
Merged: 2/12/2023
Merged by: @dani-garcia

Base: main ← Head: fix-domain-description

📝 Commits (8)

64edc49 change description of domain configuration
eb9b481 improve wording of domain description
a72d0b5 remove documentation of bug since I'm fixing it
679bc7a fix trailing slash not being removed from domain
a2aa7c9 Revert "fix trailing slash not being removed from domain"
5d1c11c fix trailing slash in configuration builder
c04a135 remove warn when sanitizing domain
af69c83 Merge branch 'main' into fix-domain-description

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 src/config.rs (+2 -0)

📄 Description

Bitwarden send won't work if the domain includes a trailing slash. This should be documented, as it may lead to confusion among users.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3228 **Author:** [@BlockListed](https://github.com/BlockListed) **Created:** 2/6/2023 **Status:** ✅ Merged **Merged:** 2/12/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-domain-description` --- ### 📝 Commits (8) - [`64edc49`](https://github.com/dani-garcia/vaultwarden/commit/64edc49392f1786aebf6a5a0c9b60742ca734d6e) change description of domain configuration - [`eb9b481`](https://github.com/dani-garcia/vaultwarden/commit/eb9b481eba63dbbfe0e83fac238be3482e21ccfa) improve wording of domain description - [`a72d0b5`](https://github.com/dani-garcia/vaultwarden/commit/a72d0b518fa96ba63c4029f0c60e6bd53cd92661) remove documentation of bug since I'm fixing it - [`679bc7a`](https://github.com/dani-garcia/vaultwarden/commit/679bc7a59b5daef65ef7916474577106a46fa0e9) fix trailing slash not being removed from domain - [`a2aa7c9`](https://github.com/dani-garcia/vaultwarden/commit/a2aa7c9bc23145f0f5db72f8aeed826902c86fde) Revert "fix trailing slash not being removed from domain" - [`5d1c11c`](https://github.com/dani-garcia/vaultwarden/commit/5d1c11ceba3826b5ae000d9a4d8c0ec7e094428c) fix trailing slash in configuration builder - [`c04a135`](https://github.com/dani-garcia/vaultwarden/commit/c04a1352cbc62cb55e4bb412c245c832780a20df) remove warn when sanitizing domain - [`af69c83`](https://github.com/dani-garcia/vaultwarden/commit/af69c83db2a0f362dd150dffb3ba1aab230bea64) Merge branch 'main' into fix-domain-description ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/config.rs` (+2 -0) </details> ### 📄 Description Bitwarden send won't work if the domain includes a trailing slash. This should be documented, as it may lead to confusion among users. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>