[PR #3168] [CLOSED] Increase secure notes length to match LastPass. #3240

Closed
opened 2026-03-03 09:42:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3168
Author: @STRML
Created: 1/25/2023
Status: Closed

Base: mainHead: fix/secure-notes-length


📝 Commits (1)

  • 15eeaee Increase secure notes length to match LastPass.

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 src/api/core/ciphers.rs (+2 -2)
📝 src/db/models/cipher.rs (+2 -2)

📄 Description

As users are migrating from LastPass, I am seeing more and more people hitting the max length of 10,000 on the "Notes" field, which applies to both CipherType.Login and CipherType.SecureNote.

This default is too low, and by being significantly lower than competing products, needlessly complicates the transition.

This is not helped by how unhelpful the import process is on web (showing errors in console only, silently dropping items), which is a PR for another day. By merging this, we can ensure that one of the most common drop-offs is fixed.

45,000 matches LastPass. As we know that the encrypted length can be longer than the raw text, I have increased this to 50,000 so there is a healthy buffer to account for this inflation.

Mirrors PR at https://github.com/bitwarden/server/pull/2625


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3168 **Author:** [@STRML](https://github.com/STRML) **Created:** 1/25/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/secure-notes-length` --- ### 📝 Commits (1) - [`15eeaee`](https://github.com/dani-garcia/vaultwarden/commit/15eeaee6bc9bdb781dff33ac0d5f14aa9de2250c) Increase secure notes length to match LastPass. ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+2 -2) 📝 `src/db/models/cipher.rs` (+2 -2) </details> ### 📄 Description As users are migrating from LastPass, I am seeing more and more people hitting the max length of 10,000 on the "Notes" field, which applies to both CipherType.Login and CipherType.SecureNote. This default is too low, and by being significantly lower than competing products, needlessly complicates the transition. This is not helped by how unhelpful the import process is on web (showing errors in console only, silently dropping items), which is a PR for another day. By merging this, we can ensure that one of the most common drop-offs is fixed. 45,000 matches LastPass. As we know that the encrypted length can be longer than the raw text, I have increased this to 50,000 so there is a healthy buffer to account for this inflation. Mirrors PR at https://github.com/bitwarden/server/pull/2625 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:42:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3240
No description provided.