mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 01:35:54 +03:00
[PR #3168] [CLOSED] Increase secure notes length to match LastPass. #3240
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#3240
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3168
Author: @STRML
Created: 1/25/2023
Status: ❌ Closed
Base:
main← Head:fix/secure-notes-length📝 Commits (1)
15eeaeeIncrease secure notes length to match LastPass.📊 Changes
2 files changed (+4 additions, -4 deletions)
View changed files
📝
src/api/core/ciphers.rs(+2 -2)📝
src/db/models/cipher.rs(+2 -2)📄 Description
As users are migrating from LastPass, I am seeing more and more people hitting the max length of 10,000 on the "Notes" field, which applies to both CipherType.Login and CipherType.SecureNote.
This default is too low, and by being significantly lower than competing products, needlessly complicates the transition.
This is not helped by how unhelpful the import process is on web (showing errors in console only, silently dropping items), which is a PR for another day. By merging this, we can ensure that one of the most common drop-offs is fixed.
45,000 matches LastPass. As we know that the encrypted length can be longer than the raw text, I have increased this to 50,000 so there is a healthy buffer to account for this inflation.
Mirrors PR at https://github.com/bitwarden/server/pull/2625
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.