mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-04-26 09:46:00 +03:00
[PR #3170] [MERGED] Allow listening on privileged ports (below 1024) as non-root #3239
Labels
No labels
SSO
Third party
better for forum
bug
bug
documentation
duplicate
enhancement
future Vault
future Vault
future Vault
good first issue
help wanted
low priority
notes
pull-request
question
troubleshooting
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/vaultwarden#3239
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3170
Author: @jjlin
Created: 1/25/2023
Status: ✅ Merged
Merged: 2/12/2023
Merged by: @dani-garcia
Base:
main← Head:cap_net_bind_service📝 Commits (4)
2c6bd8cRename.buildxDockerfiles to.buildkit686474fDisable Hadolint check for consecutiveRUNinstructions (DL3059)a2162f4Allow listening on privileged ports (below 1024) as non-roota6dd4f1Merge branch 'main' into cap_net_bind_service📊 Changes
21 files changed (+175 additions, -216 deletions)
View changed files
📝
.github/workflows/release.yml(+4 -1)📝
.hadolint.yaml(+2 -0)📝
docker/Dockerfile.j2(+28 -26)📝
docker/Makefile(+2 -2)📝
docker/amd64/Dockerfile(+5 -9)📝
docker/amd64/Dockerfile.alpine(+4 -7)📝
docker/amd64/Dockerfile.buildkit(+10 -9)📝
docker/amd64/Dockerfile.buildkit.alpine(+9 -7)📝
docker/arm64/Dockerfile(+9 -16)📝
docker/arm64/Dockerfile.alpine(+4 -9)📝
docker/arm64/Dockerfile.buildkit(+14 -16)📝
docker/arm64/Dockerfile.buildkit.alpine(+9 -9)📝
docker/armv6/Dockerfile(+9 -17)📝
docker/armv6/Dockerfile.alpine(+4 -9)📝
docker/armv6/Dockerfile.buildkit(+14 -17)📝
docker/armv6/Dockerfile.buildkit.alpine(+9 -9)📝
docker/armv7/Dockerfile(+9 -16)📝
docker/armv7/Dockerfile.alpine(+4 -9)📝
docker/armv7/Dockerfile.buildkit(+14 -16)📝
docker/armv7/Dockerfile.buildkit.alpine(+9 -9)...and 1 more files
📄 Description
This is done by running
setcap cap_net_bind_service=+epon the executable in the build stage (doing it in the runtime stage creates an extra copy of the executable that bloats the image). This only works when using the BuildKit-based builder, since theCOPYinstruction doesn't copy capabilities on the legacy builder.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.